r38251 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r38250‎ | r38251 | r38252 >
Date:20:14, 30 July 2008
Author:brion
Status:old
Tags:
Comment:
Revert r38214 (IPv6 check for $wgServerName) -- failing to load IP class in some situations as seen on Wikimedia live installation.
Haven't been able to reproduce locally, though.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/DefaultSettings.php
@@ -69,12 +69,6 @@
7070 $wgServerName = 'localhost';
7171 }
7272
73 -# Before we put http:// and other things onto it, need to
74 -# wrap IPv6 in []. Bug 14977.
75 -if ( IP::isIPv6( $wgServerName ) ) {
76 - $wgServerName = '[' . $wgServerName . ']';
77 -}
78 -
7973 # check if server use https:
8074 $wgProto = (isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == 'on') ? 'https' : 'http';
8175
Index: trunk/phase3/RELEASE-NOTES
@@ -45,8 +45,6 @@
4646 * (bug 14954) Fix regression in Modern and Simple skins
4747 * Recursion loop check added to Categoryfinder class
4848 * Fixed few performance troubles of large job queue processing
49 -* (bug 14977) Installations on servers using IPv6 addresses for $wgServer
50 - were largely unusable because $wgServer didn't wrap the IP in brackets.
5149
5250 === API changes in 1.14 ===
5351

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r38214(bug 14977) Installations on servers using IPv6 addresses for $wgServer were ...demon03:23, 30 July 2008

Status & tagging log