r36979 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36978‎ | r36979 | r36980 >
Date:12:25, 3 July 2008
Author:rotem
Status:old
Tags:
Comment:
Replacing the fix for bug 12716.
Modified paths:
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
@@ -1358,11 +1358,6 @@
13591359 $dbw->delete( 'protected_titles', array( 'pt_namespace' => $namespace,
13601360 'pt_title' => $title ), __METHOD__ );
13611361 }
1362 - if($dbw->affectedRows() == 0) {
1363 - //No Change
1364 - return true;
1365 - }
1366 -
13671362 # Update the protection log
13681363 $log = new LogPage( 'protect' );
13691364
@@ -1818,6 +1813,8 @@
18191814 } else { // Get rid of the old restrictions
18201815 Title::purgeExpiredRestrictions();
18211816 }
 1817+ } else {
 1818+ $this->mRestrictionsExpiry = Block::decodeExpiry('');
18221819 }
18231820 $this->mRestrictionsLoaded = true;
18241821 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r44493(bug 12716) Unprotecting a non-protected page leaves a log entryaaron04:55, 12 December 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r30020(bug 12716) Unprotecting a non-protected page leaves a log entrycatrope15:04, 21 January 2008
r31322(bug 13132) Unable to unprotect pages protected with earlier versions of Medi...rotem20:41, 26 February 2008
r36967bug 12716 - trying to unprotect a title that isn't protected no longer genera...demon05:25, 3 July 2008

Status & tagging log