r36967 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36966‎ | r36967 | r36968 >
Date:05:25, 3 July 2008
Author:demon
Status:old
Tags:
Comment:
bug 12716 - trying to unprotect a title that isn't protected no longer generates a log entry.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
@@ -1358,6 +1358,11 @@
13591359 $dbw->delete( 'protected_titles', array( 'pt_namespace' => $namespace,
13601360 'pt_title' => $title ), __METHOD__ );
13611361 }
 1362+ if($dbw->affectedRows() == 0) {
 1363+ //No Change
 1364+ return true;
 1365+ }
 1366+
13621367 # Update the protection log
13631368 $log = new LogPage( 'protect' );
13641369
Index: trunk/phase3/RELEASE-NOTES
@@ -410,6 +410,8 @@
411411 account creation.
412412 * (bug 3481) Pages moved shortly after creation are shown at their new title
413413 on Special:Newpages.
 414+* (bug 12716) Trying to unprotect a title that isn't protected no longer
 415+ generates a log entry.
414416
415417 === API changes in 1.13 ===
416418

Follow-up revisions

RevisionCommit summaryAuthorDate
r36979Replacing the fix for bug 12716.rotem12:25, 3 July 2008
r44493(bug 12716) Unprotecting a non-protected page leaves a log entryaaron04:55, 12 December 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r30020(bug 12716) Unprotecting a non-protected page leaves a log entrycatrope15:04, 21 January 2008
r31322(bug 13132) Unable to unprotect pages protected with earlier versions of Medi...rotem20:41, 26 February 2008

Status & tagging log