r36980 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r36979‎ | r36980 | r36981 >
Date:13:00, 3 July 2008
Author:demon
Status:old
Tags:
Comment:
Bug 14088 - excessively long block expiry times no longer bork the logpage. Reject if over 50 chars.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialBlockip.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialBlockip.php
@@ -339,7 +339,7 @@
340340 if( $expirestr == 'other' )
341341 $expirestr = $this->BlockOther;
342342
343 - if (strlen($expirestr) == 0) {
 343+ if ((strlen($expirestr) == 0) || (strlen($expirestr) > 50)) {
344344 return array('ipb_expiry_invalid');
345345 }
346346
Index: trunk/phase3/RELEASE-NOTES
@@ -414,6 +414,8 @@
415415 on Special:Newpages.
416416 * (bug 12716) Trying to unprotect a title that isn't protected no longer
417417 generates a log entry.
 418+* (bug 14088) Excessively long block expiry times are rejected as invalid,
 419+ keeps the log page from being distorted.
418420
419421 === API changes in 1.13 ===
420422

Status & tagging log