r30020 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r30019‎ | r30020 | r30021 >
Date:15:04, 21 January 2008
Author:catrope
Status:old
Tags:
Comment:
(bug 12716) Unprotecting a non-protected page leaves a log entry
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
@@ -1766,9 +1766,6 @@
17671767 if ( $cascade )
17681768 $comment .= "$cascade_description";
17691769
1770 - $nullRevision = Revision::newNullRevision( $dbw, $id, $comment, true );
1771 - $nullRevId = $nullRevision->insertOn( $dbw );
1772 -
17731770 # Update restrictions table
17741771 foreach( $limit as $action => $restrictions ) {
17751772 if ($restrictions != '' ) {
@@ -1781,7 +1778,14 @@
17821779 'pr_type' => $action ), __METHOD__ );
17831780 }
17841781 }
 1782+ if($dbw->affectedRows() == 0)
 1783+ // No change
 1784+ return true;
17851785
 1786+ # Insert a null revision
 1787+ $nullRevision = Revision::newNullRevision( $dbw, $id, $comment, true );
 1788+ $nullRevId = $nullRevision->insertOn( $dbw );
 1789+
17861790 # Update page record
17871791 $dbw->update( 'page',
17881792 array( /* SET */
Index: trunk/phase3/RELEASE-NOTES
@@ -136,10 +136,6 @@
137137 * (bug 10049) Prefix index search and namespaces in Special:Withoutinterwiki
138138 * (bug 12668) Support for custom iPhone bookmark icon via $wgAppleTouchIcon
139139 * Add option to include templates in Special:Export.
140 -* (bug 12655) Added $wgUserEmailUseReplyTo config option to put sender
141 - address in Reply-To instead of From for user-to-user emails.
142 - This protects against SPF problems and privacy-leaking bounce messages
143 - when using mailers that set the envelope sender to the From header value.
144140
145141
146142 === Bug fixes in 1.12 ===
@@ -326,6 +322,7 @@
327323 * Creating a site with a name containing '#' is no longer permitted, since the
328324 name will not work (but $wgSiteName is not checked if manually set).
329325 * (bug 12695) Suppress dvips verbiage from web server error log
 326+* (bug 12716) Unprotecting a non-protected page leaves a log entry
330327
331328
332329 == Parser changes in 1.12 ==

Follow-up revisions

RevisionCommit summaryAuthorDate
r30027* re-add bug 12655 that was added in r30014 and disappeared in r30020...siebrand18:13, 21 January 2008
r31322(bug 13132) Unable to unprotect pages protected with earlier versions of Medi...rotem20:41, 26 February 2008
r36967bug 12716 - trying to unprotect a title that isn't protected no longer genera...demon05:25, 3 July 2008
r36979Replacing the fix for bug 12716.rotem12:25, 3 July 2008
r44493(bug 12716) Unprotecting a non-protected page leaves a log entryaaron04:55, 12 December 2008

Status & tagging log