r2952 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r2951‎ | r2952 | r2953 >
Date:01:46, 4 April 2004
Author:gabrielwicke
Status:old
Tags:
Comment:
got rid of a few surplus id's
Modified paths:
  • /trunk/phase3/templates/xhtml_slim.pt (modified) (history)

Diff [purge]

Index: trunk/phase3/templates/xhtml_slim.pt
@@ -9,22 +9,14 @@
1010 <style type="text/css" media="screen">
1111 /*<![CDATA[*/
1212 @import url(${stylepath}/${skinname}/main.css);
 13+ /* custom css, could be either a pref or a subpage of the the user page */
 14+ /* @import url(${stylepath}/custom.css); */
1315 /*]]>*/
1416 </style>
15 - <!-- Custom style sheet if available, could either be a pref or a subpage of the user page
16 - <style type="text/css" media="all">
17 - /*<![CDATA[*/
18 - @import url(${stylepath}/custom.css);
19 - /*]]>*/
20 - </style>-->
21 - <!-- Style sheet used for printing -->
2217 <link rel="stylesheet" type="text/css" media="print" href="${stylepath}/commonPrint.css" />
23 - <!-- insane fixes as usual --><!--[if IE]>
24 - <style type="text/css" media="all">@import url(${stylepath}/${skinname}/IEFixes.css);</style>
25 - <![endif]-->
 18+ <!--[if IE]><style type="text/css" media="all">@import url(${stylepath}/${skinname}/IEFixes.css);</style><![endif]-->
2619 <link tal:condition="favicon" rel="shortcut icon" href="${favicon}" type="image/x-icon" />
27 - <!-- Disable IE6 image toolbar -->
28 - <meta http-equiv="imagetoolbar" content="no" />
 20+ <!-- Disable IE6 image toolbar --><meta http-equiv="imagetoolbar" content="no" />
2921 <script type="text/javascript" src="${stylepath}/wikibits.js">
3022 </script>
3123 </head>
@@ -35,24 +27,22 @@
3628 <div id="portal-column-content">
3729 <div id="content">
3830 <a name="top" id="contentTop"></a>
39 - <div class="documentContent">
 31+ <div id="documentContent">
4032
4133 <h1 class="documentFirstHeading" tal:content="title">Leonardo da Vinci</h1>
4234
43 - <div id="bodyContent" class="plain">
 35+ <div id="bodyContent">
4436 <h3 id="siteSubtitle" i18n:translate="string:fromwikipedia">From Wikipedia, the free encyclopedia.</h3>
4537 <div tal:condition="subtitle" id="documentSubtitle" tal:content="structure subtitle"></div>
4638 <!-- <esi:include src="userxy/message"/> cached per user, purged on new message-->
4739 <div tal:condition="newtalk" class="portalMessage" tal:content="newtalk"></div>
4840 <!-- the content area is cached with the remaining inexpensive sceleton, one version for all.
49 - The edit links and right-click section stuff is attached from js -->
 41+ The edit links and right-click section stuff can be attached from js -->
5042 <!-- start content -->
5143
5244 ${bodytext}
5345
5446 <!-- end content -->
55 - <div class="documentByLine">
56 - </div>
5747 </div>
5848 </div>
5949 </div>
@@ -63,20 +53,17 @@
6454 <!--<esi:include src="thisurl?esiview=contentviews&watch=0&priv=sysop"/> tricky to purge because of the many different versions,
6555 might not be worth it for non-anons -->
6656 <div id="portlet-contentViews" class="portlet">
67 - <h5 class="hiddenStructure">Views</h5>
68 -
69 - <ul class="contentViews">
 57+ <h5>Views</h5>
 58+ <ul>
7059 <li tal:repeat="action content_actions"
7160 tal:attributes="id string:contentaction-${repeat/action/key}; class action/class|default"><a
7261 tal:attributes="title action/ttip|default; accesskey action/akey|default;href action/href|default"
7362 tal:content="action/text">Linktext</a></li>
7463 </ul>
75 -
7664 </div>
7765 <!--<esi:include src="userxy?personaltools"/> cached per user, just rendered once per session -->
7866 <div class="portlet" id="portlet-personal">
79 - <h5 class="hiddenStructure" i18n:translate="string:personaltools">Personal Tools</h5>
80 -
 67+ <h5 i18n:translate="string:personaltools">Personal Tools</h5>
8168 <div class="portletBody">
8269 <div class="portletContent odd">
8370 <ul id="portal-personaltools">
@@ -92,25 +79,20 @@
9380 <div class="portlet" id="portlet-logo">
9481 <a href="${nav_urls/mainpage/href}" i18n:attributes="title string:mainpage"></a>
9582 </div>
96 -
97 - <div class="portlet" id="portlet-navigation-tree">
 83+ <div class="portlet" id="portlet-navigation">
9884 <h5 i18n:translate="string:navigation">Navigation</h5>
99 -
10085 <div class="portletBody">
10186 <div class="portletContent odd">
10287 <ul>
10388 <li><a href="${nav_urls/mainpage/href}"
10489 i18n:attributes="accesskey string:accesskey-mainpage | default; title string:tooltip-mainpage"
10590 i18n:translate="string:mainpage">Main Page</a></li>
106 -
10791 <li><a href="${nav_urls/randompage/href}"
10892 i18n:attributes="accesskey string:accesskey-randompage | default; title string:tooltip-randompage"
10993 i18n:translate="string:randompage">Random Page</a></li>
110 -
111 - <li condition="${nav_urls/currentevents/href}"><a href="${nav_urls/currentevents/href}"
 94+ <li tal:condition="${nav_urls/currentevents/href}"><a href="${nav_urls/currentevents/href}"
11295 i18n:attributes="title string:tooltip-currentevents|default"
11396 i18n:translate="string:currentevents">Current Events</a></li>
114 -
11597 <li><a href="${nav_urls/sitesupport/href}"
11698 i18n:attributes="title string:tooltip-sitesupport|default"
11799 i18n:translate="string:sitesupport">Donations</a></li>
@@ -118,16 +100,13 @@
119101 </div>
120102 </div>
121103 </div>
122 -
123104 <div id="portlet-search" class="portlet">
124105 <h5 i18n:translate="string:search">Search</h5>
125 -
126106 <div class="portletBody">
127107 <div class="portletContent odd">
128108 <form name="searchform" action="${searchaction}" id="searchform">
129109 <input id="searchGadget" name="search" type="text" tabindex="30001"
130110 i18n:attributes="accesskey string:accesskey-search | default"/>
131 -
132111 <input type='submit' name="go" value="Go" class="searchButton"
133112 i18n:attributes="value string:go"/>&nbsp;<input type='submit'
134113 value="Search" class="searchButton"
@@ -136,7 +115,6 @@
137116 </div>
138117 </div>
139118 </div>
140 -
141119 <!--<esi:include src="thisurl?esiview=toolbox&loggedin=0"/> one anon, one logged-in user version per page because of the links -->
142120 <div class="portlet" id="portlet-toolbox">
143121 <h5 i18n:translate="string:toolbox">Toolbox</h5>
@@ -144,31 +122,24 @@
145123 <div class="portletBody">
146124 <div class="portletContent odd">
147125 <ul>
148 -
149126 <li><a href="${nav_urls/help/href}"
150127 i18n:attributes="title string:tooltip-help|default"
151128 i18n:translate="string:help">Help</a></li>
152 -
153129 <li><a href="${nav_urls/recentchanges/href}"
154130 i18n:attributes="accesskey string:accesskey-recentchanges|default; title string:tooltip-recentchanges|default"
155131 i18n:translate="string:recentchanges">Recent Changes</a></li>
156 -
157132 <li><a href="${nav_urls/recentchangeslinked/href}"
158133 i18n:attributes="title string:tooltip-recentchangeslinked | default"
159134 i18n:translate="string:recentchangeslinked">Related Changes</a></li>
160 -
161135 <li><a href="${nav_urls/whatlinkshere/href}"
162136 i18n:attributes="accesskey string:accesskey-whatlinkshere|default; title string:tooltip-whatlinkshere|default"
163137 i18n:translate="string:whatlinkshere">What links here</a></li>
164 -
165138 <li><a href="${nav_urls/specialpages/href}"
166139 i18n:attributes="title string:tooltip-specialpages|default"
167140 i18n:translate="string:specialpages">Special Pages</a></li>
168 -
169141 <li tal:condition="loggedin"><a href="${nav_urls/upload/href"
170142 i18n:attributes="accesskey string:accesskey-upload|default; title string:tooltip-upload|default"
171143 i18n:translate="string:upload">Upload a file</a></li>
172 -
173144 </ul>
174145 </div>
175146 </div>
@@ -177,7 +148,6 @@
178149
179150 <div id="portlet-language" class="portlet" tal:condition="language_urls">
180151 <h5 i18n:translate="string:otherlanguages">Language</h5>
181 -
182152 <div class="portletBody">
183153 <div class="portletContent odd">
184154 <ul>

Status & tagging log