r26433 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r26432‎ | r26433 | r26434 >
Date:07:37, 5 October 2007
Author:amidaniel
Status:old
Tags:
Comment:
API: Ensure it checks *only* the fast limit or the slow limit, not both. On fast revision queries (those without content), was checking once against fast limit and once against slow limit, and exploding if limit exceeded slow limit.
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryRevisions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryRevisions.php
——@@ -278,8 +278,8 @@
279279 'limit' => array (
280280 ApiBase :: PARAM_TYPE => 'limit',
281281 ApiBase :: PARAM_MIN => 1,
282 - ApiBase :: PARAM_MAX => ApiBase :: LIMIT_SML1,
283 - ApiBase :: PARAM_MAX2 => ApiBase :: LIMIT_SML2
 282+ ApiBase :: PARAM_MAX => ApiBase :: LIMIT_BIG1,
 283+ ApiBase :: PARAM_MAX2 => ApiBase :: LIMIT_BIG2
284284 ),
285285 'startid' => array (
286286 ApiBase :: PARAM_TYPE => 'integer'

Follow-up revisions

RevisionCommit summaryAuthorDate
r26445API: Forgot to document r26433 (rvlimit).amidaniel02:35, 6 October 2007
r26448Merged revisions 26431-26447 via svnmerge from...david05:36, 6 October 2007

Status & tagging log