r26448 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r26447‎ | r26448 | r26449 >
Date:05:36, 6 October 2007
Author:david
Status:old
Tags:
Comment:
Merged revisions 26431-26447 via svnmerge from
svn+ssh://david@svn.wikimedia.org/svnroot/mediawiki/trunk/phase3

........
r26433 | amidaniel | 2007-10-05 00:37:58 -0700 (Fri, 05 Oct 2007) | 2 lines

API: Ensure it checks *only* the fast limit or the slow limit, not both. On fast revision queries (those without content), was checking once against fast limit and once against slow limit, and exploding if limit exceeded slow limit.
........
r26444 | amidaniel | 2007-10-05 19:30:00 -0700 (Fri, 05 Oct 2007) | 2 lines

API: Include, if possible, svn rev in siteinfo query result.
........
r26445 | amidaniel | 2007-10-05 19:35:27 -0700 (Fri, 05 Oct 2007) | 2 lines

API: Forgot to document r26433 (rvlimit).
........
Modified paths:
  • /branches/liquidthreads (modified) (history)
  • /branches/liquidthreads/RELEASE-NOTES (modified) (history)
  • /branches/liquidthreads/includes/api/ApiQueryRevisions.php (modified) (history)
  • /branches/liquidthreads/includes/api/ApiQuerySiteinfo.php (modified) (history)

Diff [purge]

Index: branches/liquidthreads/includes/api/ApiQuerySiteinfo.php
@@ -68,7 +68,7 @@
6969 }
7070
7171 protected function appendGeneralInfo($property) {
72 - global $wgSitename, $wgVersion, $wgCapitalLinks, $wgRightsCode, $wgRightsText, $wgLanguageCode;
 72+ global $wgSitename, $wgVersion, $wgCapitalLinks, $wgRightsCode, $wgRightsText, $wgLanguageCode, $IP;
7373
7474 $data = array ();
7575 $mainPage = Title :: newFromText(wfMsgForContent('mainpage'));
@@ -76,6 +76,10 @@
7777 $data['base'] = $mainPage->getFullUrl();
7878 $data['sitename'] = $wgSitename;
7979 $data['generator'] = "MediaWiki $wgVersion";
 80+
 81+ $svn = SpecialVersion::getSvnRevision ( $IP );
 82+ if ( $svn ) $data['rev'] = $svn;
 83+
8084 $data['case'] = $wgCapitalLinks ? 'first-letter' : 'case-sensitive'; // 'case-insensitive' option is reserved for future
8185 if (isset($wgRightsCode))
8286 $data['rightscode'] = $wgRightsCode;
@@ -231,4 +235,4 @@
232236 public function getVersion() {
233237 return __CLASS__ . ': $Id$';
234238 }
235 -}
\ No newline at end of file
 239+}
Index: branches/liquidthreads/includes/api/ApiQueryRevisions.php
@@ -278,8 +278,8 @@
279279 'limit' => array (
280280 ApiBase :: PARAM_TYPE => 'limit',
281281 ApiBase :: PARAM_MIN => 1,
282 - ApiBase :: PARAM_MAX => ApiBase :: LIMIT_SML1,
283 - ApiBase :: PARAM_MAX2 => ApiBase :: LIMIT_SML2
 282+ ApiBase :: PARAM_MAX => ApiBase :: LIMIT_BIG1,
 283+ ApiBase :: PARAM_MAX2 => ApiBase :: LIMIT_BIG2
284284 ),
285285 'startid' => array (
286286 ApiBase :: PARAM_TYPE => 'integer'
Index: branches/liquidthreads/RELEASE-NOTES
@@ -105,6 +105,9 @@
106106 * (bug 11404) Provide name of exception caught in error code field of internal api
107107 error messages.
108108 * (bug 11534) rvendid doesn't work
 109+* Fixed rvlimit of the revisions query to only enforce the lower query limit if
 110+ revision content is requested.
 111+* Include svn revision number (if install is checked-out from svn) in siteinfo query.
109112
110113 === Languages updated in 1.12 ===
111114
Property changes on: branches/liquidthreads
___________________________________________________________________
Modified: svnmerge-integrated
112115 - /trunk/phase3:1-26430
113116 + /trunk/phase3:1-26447

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r26433API: Ensure it checks *only* the fast limit or the slow limit, not both. On f...amidaniel07:37, 5 October 2007
r26444API: Include, if possible, svn rev in siteinfo query result.amidaniel02:30, 6 October 2007
r26445API: Forgot to document r26433 (rvlimit).amidaniel02:35, 6 October 2007

Status & tagging log