r26432 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r26431‎ | r26432 | r26433 >
Date:07:05, 5 October 2007
Author:david
Status:old
Tags:
Comment:
some minor changes toward extensification.
Modified paths:
  • /branches/liquidthreads/extensions/LqtPages.php (modified) (history)
  • /branches/liquidthreads/includes/Defines.php (modified) (history)
  • /branches/liquidthreads/includes/EditPage.php (modified) (history)
  • /branches/liquidthreads/includes/Namespace.php (modified) (history)
  • /branches/liquidthreads/includes/SkinTemplate.php (modified) (history)
  • /branches/liquidthreads/includes/SpecialPage.php (modified) (history)
  • /branches/liquidthreads/includes/Wiki.php (modified) (history)

Diff [purge]

Index: branches/liquidthreads/extensions/LqtPages.php
@@ -12,6 +12,16 @@
1313 die( -1 );
1414 }
1515
 16+define('NS_LQT_THREAD', 16);
 17+define('NS_LQT_THREAD_TALK', 17);
 18+define('NS_LQT_SUMMARY', 18);
 19+define('NS_LQT_SUMMARY_TALK', 19);
 20+
 21+$wgCanonicalNamespaceNames[NS_LQT_THREAD] = 'Thread';
 22+$wgCanonicalNamespaceNames[NS_LQT_THREAD_TALK] = 'Thread_talk';
 23+$wgCanonicalNamespaceNames[NS_LQT_SUMMARY] = 'Summary';
 24+$wgCanonicalNamespaceNames[NS_LQT_SUMMARY_TALK] = 'Summary_talk';
 25+
1626 require_once('LqtBaseView.php');
1727 require_once('LqtI18N.php');
1828
Index: branches/liquidthreads/includes/Defines.php
@@ -61,10 +61,6 @@
6262 define('NS_HELP_TALK', 13);
6363 define('NS_CATEGORY', 14);
6464 define('NS_CATEGORY_TALK', 15);
65 -define('NS_LQT_THREAD', 16);
66 -define('NS_LQT_THREAD_TALK', 17);
67 -define('NS_LQT_SUMMARY', 18);
68 -define('NS_LQT_SUMMARY_TALK', 19);
6965 /**#@-*/
7066
7167 /**
Index: branches/liquidthreads/includes/EditPage.php
@@ -47,8 +47,8 @@
4848 public $editFormTextAfterTools;
4949 public $editFormTextBottom;
5050
51 - public $didSave = false; # LQT HACK.
52 - public $suppressIntro = false; # LQT HACK.
 51+ public $didSave = false;
 52+ public $suppressIntro = false;
5353
5454 /**
5555 * @todo document
@@ -595,7 +595,7 @@
596596 */
597597 private function showIntro() {
598598 global $wgOut, $wgUser;
599 - if ( $this->suppressIntro ) return; # LQT HACK.
 599+ if ( $this->suppressIntro ) return;
600600 if( !$this->showCustomIntro() && !$this->mArticle->getTitle()->exists() ) {
601601 if( $wgUser->isLoggedIn() ) {
602602 $wgOut->addWikiText( wfMsg( 'newarticletext' ) );
@@ -750,7 +750,7 @@
751751 $isComment=($this->section=='new');
752752 $this->mArticle->insertNewArticle( $this->textbox1, $this->summary,
753753 $this->minoredit, $this->watchthis, false, $isComment);
754 - $this->didSave = true; # LQT HACK.
 754+ $this->didSave = true;
755755
756756 wfProfileOut( $fname );
757757 return false;
@@ -888,7 +888,7 @@
889889 # update the article here
890890 if( $this->mArticle->updateArticle( $text, $this->summary, $this->minoredit,
891891 $this->watchthis, '', $sectionanchor ) ) {
892 - $this->didSave = true; # LQT HACK.
 892+ $this->didSave = true;
893893 wfProfileOut( $fname );
894894 return false;
895895 } else {
Index: branches/liquidthreads/includes/Wiki.php
@@ -371,7 +371,6 @@
372372
373373 wfProfileIn( 'MediaWiki::performAction' );
374374
375 - // TODO LQT HACK
376375 if ( !wfRunHooks('MediaWikiPerformAction', array($output, $article, $title, $user, $request)) ) {
377376 wfProfileOut( 'MediaWiki::performAction' );
378377 return;
Index: branches/liquidthreads/includes/Namespace.php
@@ -25,10 +25,6 @@
2626 NS_HELP_TALK => 'Help_talk',
2727 NS_CATEGORY => 'Category',
2828 NS_CATEGORY_TALK => 'Category_talk',
29 - NS_LQT_THREAD => 'Thread',
30 - NS_LQT_THREAD_TALK => 'Thread_talk',
31 - NS_LQT_SUMMARY => 'Summary',
32 - NS_LQT_SUMMARY_TALK => 'Summary_talk',
3329 );
3430
3531 if( is_array( $wgExtraNamespaces ) ) {
Index: branches/liquidthreads/includes/SkinTemplate.php
@@ -765,6 +765,7 @@
766766 );
767767 }
768768 }
 769+
769770
770771 wfRunHooks( 'SkinTemplateTabs', array( &$this , &$content_actions ) ) ;
771772 } else {
Index: branches/liquidthreads/includes/SpecialPage.php
@@ -75,7 +75,6 @@
7676
7777 /**
7878 * Should the subpage part be removed from titles in executePath()?
79 - * LQT HACK.
8079 **/
8180 static public $mStripSubpages = true;
8281
@@ -455,7 +454,7 @@
456455 wfProfileOut( __METHOD__ );
457456 return false;
458457 } elseif ( !$including ) {
459 - $wgTitle = $page->getTitle( SpecialPage::$mStripSubpages ? '' : $par ); # LQT HACK didn't have $par here.
 458+ $wgTitle = $page->getTitle( SpecialPage::$mStripSubpages ? '' : $par );
460459 }
461460 $page->including( $including );
462461

Status & tagging log