r23180 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r23179‎ | r23180 | r23181 >
Date:21:02, 21 June 2007
Author:robchurch
Status:old
Tags:
Comment:
Revert bogus r23161
Modified paths:
  • /trunk/extensions/LdapAuthentication/LdapAuthentication.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LdapAuthentication/LdapAuthentication.php
@@ -1615,7 +1615,7 @@
16161616 //They already with us? If so, quit this function.
16171617 if( $tmpuser->isLoggedIn() ) {
16181618 $wgAuth->printDebug( "User is already logged in.", 1 );
1619 - return true;
 1619+ return false;
16201620 }
16211621
16221622 //Let regular authentication plugins configure themselves for auto
@@ -1629,7 +1629,7 @@
16301630 //If the user doesn't exist in LDAP, there isn't much reason to
16311631 //go any further.
16321632 $wgAuth->printDebug("User wasn't found in LDAP, exiting.", 1 );
1633 - return true;
 1633+ return false;
16341634 }
16351635
16361636 //We need the username that MediaWiki will always use, *not* the one we
@@ -1643,7 +1643,7 @@
16441644
16451645 if ( $tmpuser == null ) {
16461646 $wgAuth->printDebug( "Username is not a valid MediaWiki username.", 1 );
1647 - return true;
 1647+ return false;
16481648 }
16491649
16501650 //If exists, log them in
@@ -1653,7 +1653,7 @@
16541654 $wgAuth->updateUser( $wgUser );
16551655 $wgUser->setCookies();
16561656 $wgUser->setupSession();
1657 - return true;
 1657+ return false;
16581658 }
16591659 $wgAuth->printDebug( "User does not exist in local database; creating.", 1 );
16601660

Follow-up revisions

RevisionCommit summaryAuthorDate
r23232*Fix bogus change in r23180 (talked to Ryan about this)aaron17:16, 22 June 2007

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r23161*Return true for hooksaaron13:53, 21 June 2007

Status & tagging log