r16988 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r16987‎ | r16988 | r16989 >
Date:07:06, 13 October 2006
Author:simetrical
Status:old
Tags:
Comment:
(bug 2013) Use numbers instead of em specifications for line-height so that the ratio and not the computed value is inherited.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/skins/chick/main.css (modified) (history)
  • /trunk/phase3/skins/common/commonPrint.css (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)
  • /trunk/phase3/skins/simple/main.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/chick/main.css
——@@ -28,7 +28,7 @@
2929 }
3030 p {
3131 margin: 0.4em 0em 0.5em 0em;
32 - line-height: 1.5em;
 32+ line-height: 1.5;
3333 }
3434
3535 p img { margin: 0; }
——@@ -66,12 +66,12 @@
6767 }
6868
6969 ul {
70 - line-height: 1.5em;
 70+ line-height: 1.5;
7171 margin: 0.3em 0 0 1.5em;
7272 padding:0;
7373 }
7474 ol {
75 - line-height: 1.5em;
 75+ line-height: 1.5;
7676 margin: 0.3em 0 0 3.2em;
7777 padding:0;
7878 list-style-image: none;
——@@ -86,7 +86,7 @@
8787 margin-bottom: 0.5em;
8888 }
8989 dd {
90 - line-height: 1.5em;
 90+ line-height: 1.5;
9191 margin-left: 2em;
9292 margin-bottom: 0.1em;
9393 }
——@@ -95,7 +95,7 @@
9696 border: 1px solid #2f6fab;
9797 margin: 1em 0em 1em 0em;
9898 padding: 0em 1em 1em 1em;
99 - line-height: 1.5em;
 99+ line-height: 1.5;
100100 }
101101 legend {
102102 background: White;
——@@ -156,7 +156,7 @@
157157 border: 1px dashed #2f6fab;
158158 color: Black;
159159 background-color: #f9f9f9;
160 - line-height: 1.1em;
 160+ line-height: 1.1;
161161 }
162162
163163 /*
——@@ -211,7 +211,7 @@
212212 font-weight: bold;
213213 display: block;
214214 margin: 1em 0em;
215 - line-height: 1.5em;
 215+ line-height: 1.5;
216216 }
217217 .documentByLine {
218218 text-align: right;
——@@ -290,7 +290,7 @@
291291 div.thumb div div.thumbcaption {
292292 border: none;
293293 text-align: left;
294 - line-height: 1.4em;
 294+ line-height: 1.4;
295295 padding: 0.3em 0 0.1em 0;
296296 }
297297 div.magnify {
——@@ -371,7 +371,7 @@
372372 ** edit views etc
373373 */
374374 .special li {
375 - line-height: 1.4em;
 375+ line-height: 1.4;
376376 margin: 0;
377377 padding: 0;
378378 }
Index: trunk/phase3/skins/monobook/main.css
——@@ -22,7 +22,7 @@
2323 color: black;
2424 border: 1px solid #aaa;
2525 border-right: none;
26 - line-height: 1.5em;
 26+ line-height: 1.5;
2727 position: relative;
2828 z-index: 2;
2929 }
——@@ -95,7 +95,7 @@
9696 }
9797 p {
9898 margin: .4em 0 .5em 0;
99 - line-height: 1.5em;
 99+ line-height: 1.5;
100100 }
101101 p img {
102102 margin: 0;
——@@ -135,14 +135,14 @@
136136 }
137137
138138 ul {
139 - line-height: 1.5em;
 139+ line-height: 1.5;
140140 list-style-type: square;
141141 margin: .3em 0 0 1.5em;
142142 padding: 0;
143143 list-style-image: url(bullet.gif);
144144 }
145145 ol {
146 - line-height: 1.5em;
 146+ line-height: 1.5;
147147 margin: .3em 0 0 3.2em;
148148 padding: 0;
149149 list-style-image: none;
——@@ -159,7 +159,7 @@
160160 margin-bottom: .5em;
161161 }
162162 dd {
163 - line-height: 1.5em;
 163+ line-height: 1.5;
164164 margin-left: 2em;
165165 margin-bottom: .1em;
166166 }
——@@ -168,7 +168,7 @@
169169 border: 1px solid #2f6fab;
170170 margin: 1em 0 1em 0;
171171 padding: 0 1em 1em;
172 - line-height: 1.5em;
 172+ line-height: 1.5;
173173 }
174174 legend {
175175 padding: .5em;
——@@ -217,7 +217,7 @@
218218 border: 1px dashed #2f6fab;
219219 color: black;
220220 background-color: #f9f9f9;
221 - line-height: 1.1em;
 221+ line-height: 1.1;
222222 }
223223
224224 /*
——@@ -234,7 +234,7 @@
235235
236236 #contentSub, #contentSub2 {
237237 font-size: 84%;
238 - line-height: 1.2em;
 238+ line-height: 1.2;
239239 margin: 0 0 1.4em 1em;
240240 color: #7d7d7d;
241241 width: auto;
——@@ -315,7 +315,7 @@
316316 font-weight: bold;
317317 display: block;
318318 margin: 1em 0;
319 - line-height: 1.5em;
 319+ line-height: 1.5;
320320 }
321321 .documentByLine {
322322 text-align: right;
——@@ -437,7 +437,7 @@
438438 div.thumb div div.thumbcaption {
439439 border: none;
440440 text-align: left;
441 - line-height: 1.4em;
 441+ line-height: 1.4;
442442 padding: .3em 0 .1em 0;
443443 }
444444 div.magnify {
——@@ -523,7 +523,7 @@
524524 ** edit views etc
525525 */
526526 .special li {
527 - line-height: 1.4em;
 527+ line-height: 1.4;
528528 margin: 0;
529529 padding: 0;
530530 }
——@@ -678,7 +678,7 @@
679679 padding: 0;
680680 }
681681 .portlet ul {
682 - line-height: 1.5em;
 682+ line-height: 1.5;
683683 list-style-type: square;
684684 list-style-image: url(bullet.gif);
685685 font-size: 95%;
——@@ -780,7 +780,7 @@
781781 border: none;
782782 background: none;
783783 overflow: visible;
784 - line-height: 1.2em;
 784+ line-height: 1.2;
785785 }
786786
787787 #p-personal h5 {
——@@ -798,7 +798,7 @@
799799 /* this is the ul contained in the portlet */
800800 #p-personal ul {
801801 border: none;
802 - line-height: 1.4em;
 802+ line-height: 1.4;
803803 color: #2f6fab;
804804 padding: 0 2em 0 3em;
805805 margin: 0;
——@@ -816,7 +816,7 @@
817817 display: inline;
818818 color: #2f6fab;
819819 margin-left: 1em;
820 - line-height: 1.2em;
 820+ line-height: 1.2;
821821 background: none;
822822 }
823823 #p-personal li.active {
——@@ -856,7 +856,7 @@
857857 margin: 0;
858858 white-space: nowrap;
859859 width: 76%;
860 - line-height: 1.1em;
 860+ line-height: 1.1;
861861 overflow: visible;
862862 background: none;
863863 border-collapse: collapse;
Index: trunk/phase3/skins/common/commonPrint.css
——@@ -136,7 +136,7 @@
137137
138138 p, .documentDescription {
139139 margin: 1em 0 ! important;
140 - line-height: 1.2em;
 140+ line-height: 1.2;
141141 }
142142
143143 .tocindent p {
Index: trunk/phase3/skins/simple/main.css
——@@ -29,7 +29,7 @@
3030 margin: 0em 0 0 12.2em;
3131 padding: 0em 1em 1.5em 1em;
3232 border-left: 1px solid #959595;
33 - line-height: 1.5em;
 33+ line-height: 1.5;
3434 }
3535
3636 #column-one {
——@@ -59,7 +59,7 @@
6060 }
6161 p {
6262 margin: 0.4em 0em 0.5em 0em;
63 - line-height: 1.5em;
 63+ line-height: 1.5;
6464 }
6565 p img { margin: 0; }
6666
Index: trunk/phase3/RELEASE-NOTES
——@@ -43,6 +43,7 @@
4444 tables in Monobook
4545 * (bug 6868) Un-hardcode section edit link style
4646 * (bug 3205) Stop right floats from stacking horizontally in non-Monobook skins
 47+* (bug 2013) Inherit ratios and not computed values for line-height
4748
4849 == Languages updated ==
4950

Follow-up revisions

RevisionCommit summaryAuthorDate
r17038Adjust header line-height in Monobook to account for changes in r16988simetrical01:43, 16 October 2006