r16989 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r16988‎ | r16989 | r16990 >
Date:07:12, 13 October 2006
Author:simetrical
Status:old
Tags:
Comment:
(bug 2241) Hide watch tab on edit in favor of checkbox to avoid confusing behavior and accesskey conflict
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SkinTemplate.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SkinTemplate.php
@@ -719,7 +719,12 @@
720720 }
721721 wfProfileOut( "$fname-live" );
722722
723 - if( $this->loggedin ) {
 723+ /* If the user edits the article, then loads "watch this article" in background, and then
 724+ saves the article with "Watch this article" checkbox disabled, the article is transparently
 725+ unwatched. Therefore we do not show the "Watch this page" link in edit mode. Also avoids
 726+ accesskey conflict. */
 727+
 728+ if( $this->loggedin && $action != 'edit' && $action != 'submit' ) {
724729 if( !$this->mTitle->userIsWatching()) {
725730 $content_actions['watch'] = array(
726731 'class' => ($action == 'watch' or $action == 'unwatch') ? 'selected' : false,
Index: trunk/phase3/RELEASE-NOTES
@@ -44,6 +44,8 @@
4545 * (bug 6868) Un-hardcode section edit link style
4646 * (bug 3205) Stop right floats from stacking horizontally in non-Monobook skins
4747 * (bug 2013) Inherit ratios and not computed values for line-height
 48+* (bug 2241) Hide watch tab on edit in favor of checkbox to avoid confusing
 49+ behavior and accesskey conflict
4850
4951 == Languages updated ==
5052

Follow-up revisions

RevisionCommit summaryAuthorDate
r16991Reverting r16989 -- makes it extremely difficult to watch or unwatch a page t...brion21:03, 13 October 2006
r17118(bug 2241) Fix colliding use of 'w' and 'd' accesskeys (this time without rem...simetrical02:44, 20 October 2006