r16987 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r16986‎ | r16987 | r16988 >
Date:06:56, 13 October 2006
Author:simetrical
Status:old
Tags:
Comment:
(bug 3205) Stop right floats from stacking horizontally in non-Monobook skins (also correct clearing behavior for RTL)
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Skin.php (modified) (history)
  • /trunk/phase3/skins/CologneBlue.php (modified) (history)
  • /trunk/phase3/skins/MonoBook.php (modified) (history)
  • /trunk/phase3/skins/common/cologneblue.css (modified) (history)
  • /trunk/phase3/skins/common/common.css (modified) (history)
  • /trunk/phase3/skins/common/commonPrint.css (modified) (history)
  • /trunk/phase3/skins/common/common_rtl.css (modified) (history)
  • /trunk/phase3/skins/common/nostalgia.css (modified) (history)
  • /trunk/phase3/skins/common/wikistandard.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/CologneBlue.php
@@ -18,7 +18,7 @@
1919 class SkinCologneBlue extends Skin {
2020
2121 function getStylesheet() {
22 - return "common/cologneblue.css?3";
 22+ return "common/cologneblue.css?4";
2323 }
2424 function getSkinName() {
2525 return "cologneblue";
Index: trunk/phase3/skins/common/common.css
@@ -58,6 +58,7 @@
5959 }
6060 div.tright {
6161 float: right;
 62+ clear: right;
6263 margin-left:0.5em;
6364 }
6465 div.tleft {
Index: trunk/phase3/skins/common/cologneblue.css
@@ -1,4 +1,4 @@
2 -@import url("common.css?2");
 2+@import url("common.css?3");
33
44 body { margin: 0px; padding: 0px; color: black; }
55 #specialform { display: inline; }
Index: trunk/phase3/skins/common/commonPrint.css
@@ -67,6 +67,7 @@
6868 div.magnify { display: none; }
6969 div.tright {
7070 float: right;
 71+ clear: right;
7172 border-width: 0.5em 0 0.8em 1.4em;
7273 }
7374 div.tleft {
Index: trunk/phase3/skins/common/common_rtl.css
@@ -16,4 +16,10 @@
1717 div.editsection {
1818 float: left;
1919 margin-right: 5px;
 20+}
 21+div.tright {
 22+ clear: none;
 23+}
 24+div.tleft {
 25+ clear: left;
2026 }
\ No newline at end of file
Index: trunk/phase3/skins/common/nostalgia.css
@@ -1,4 +1,4 @@
2 -@import url("common.css?1");
 2+@import url("common.css?3");
33 body {
44 /* Background color is set separately on page type */
55 color: black;
Index: trunk/phase3/skins/common/wikistandard.css
@@ -1,4 +1,4 @@
2 -@import url("common.css?1");
 2+@import url("common.css?3");
33
44 #article { padding: 4px; }
55 #content { margin: 0; padding: 0; }
Index: trunk/phase3/skins/MonoBook.php
@@ -57,7 +57,7 @@
5858 <?php $this->html('headlinks') ?>
5959 <title><?php $this->text('pagetitle') ?></title>
6060 <style type="text/css" media="screen,projection">/*<![CDATA[*/ @import "<?php $this->text('stylepath') ?>/<?php $this->text('stylename') ?>/main.css?10"; /*]]>*/</style>
61 - <link rel="stylesheet" type="text/css" <?php if(empty($this->data['printable']) ) { ?>media="print"<?php } ?> href="<?php $this->text('stylepath') ?>/common/commonPrint.css" />
 61+ <link rel="stylesheet" type="text/css" <?php if(empty($this->data['printable']) ) { ?>media="print"<?php } ?> href="<?php $this->text('stylepath') ?>/common/commonPrint.css?1" />
6262 <!--[if lt IE 5.5000]><style type="text/css">@import "<?php $this->text('stylepath') ?>/<?php $this->text('stylename') ?>/IE50Fixes.css";</style><![endif]-->
6363 <!--[if IE 5.5000]><style type="text/css">@import "<?php $this->text('stylepath') ?>/<?php $this->text('stylename') ?>/IE55Fixes.css";</style><![endif]-->
6464 <!--[if IE 6]><style type="text/css">@import "<?php $this->text('stylepath') ?>/<?php $this->text('stylename') ?>/IE60Fixes.css";</style><![endif]-->
Index: trunk/phase3/includes/Skin.php
@@ -139,7 +139,7 @@
140140
141141 /** @return string path to the skin stylesheet */
142142 function getStylesheet() {
143 - return 'common/wikistandard.css?1';
 143+ return 'common/wikistandard.css?2';
144144 }
145145
146146 /** @return string skin name */
@@ -364,7 +364,7 @@
365365 $sheet = $this->getStylesheet();
366366 $action = $wgRequest->getText('action');
367367 $s = "@import \"$wgStylePath/$sheet\";\n";
368 - if($wgContLang->isRTL()) $s .= "@import \"$wgStylePath/common/common_rtl.css\";\n";
 368+ if($wgContLang->isRTL()) $s .= "@import \"$wgStylePath/common/common_rtl.css?1\";\n";
369369
370370 $query = "usemsgcache=yes&action=raw&ctype=text/css&smaxage=$wgSquidMaxage";
371371 $s .= '@import "' . self::makeNSUrl( 'Common.css', $query, NS_MEDIAWIKI ) . "\";\n" .
Index: trunk/phase3/RELEASE-NOTES
@@ -42,8 +42,8 @@
4343 * (bug 6918) Stopped borders and backgrounds from showing through floated
4444 tables in Monobook
4545 * (bug 6868) Un-hardcode section edit link style
 46+* (bug 3205) Stop right floats from stacking horizontally in non-Monobook skins
4647
47 -
4848 == Languages updated ==
4949
5050 * Occitan (oc)

Follow-up revisions

RevisionCommit summaryAuthorDate
r17073* Finish fixing bug 3205, and bump up $wgStyleVersion....simetrical05:02, 18 October 2006