r14306 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r14305‎ | r14306 | r14307 >
Date:08:07, 20 May 2006
Author:hashar
Status:old
Tags:
Comment:
Fix #6015: dd spacing in the boxes "edit is minor" and "watch this"
Patch by Rotem Liss <mail@rotemliss.com>
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -893,8 +893,8 @@
894894 if ( $wgUser->isAllowed('minoredit') ) {
895895 $minoredithtml =
896896 "<input tabindex='3' type='checkbox' value='1' name='wpMinoredit'".($this->minoredit?" checked='checked'":"").
897 - " accesskey='".wfMsg('accesskey-minoredit')."' id='wpMinoredit' />".
898 - "<label for='wpMinoredit' title='".wfMsg('tooltip-minoredit')."'>{$minor}</label>";
 897+ " accesskey='".wfMsg('accesskey-minoredit')."' id='wpMinoredit' />\n".
 898+ "<label for='wpMinoredit' title='".wfMsg('tooltip-minoredit')."'>{$minor}</label>\n";
899899 }
900900
901901 $watchhtml = '';
@@ -902,9 +902,9 @@
903903 if ( $wgUser->isLoggedIn() ) {
904904 $watchhtml = "<input tabindex='4' type='checkbox' name='wpWatchthis'".
905905 ($this->watchthis?" checked='checked'":"").
906 - " accesskey=\"".htmlspecialchars(wfMsg('accesskey-watch'))."\" id='wpWatchthis' />".
 906+ " accesskey=\"".htmlspecialchars(wfMsg('accesskey-watch'))."\" id='wpWatchthis' />\n".
907907 "<label for='wpWatchthis' title=\"" .
908 - htmlspecialchars(wfMsg('tooltip-watch'))."\">{$watchthis}</label>";
 908+ htmlspecialchars(wfMsg('tooltip-watch'))."\">{$watchthis}</label>\n";
909909 }
910910
911911 $checkboxhtml = $minoredithtml . $watchhtml;
@@ -927,11 +927,11 @@
928928 # Otherwise, show a summary field at the bottom
929929 $summarytext = htmlspecialchars( $wgContLang->recodeForEdit( $this->summary ) ); # FIXME
930930 if( $this->section == 'new' ) {
931 - $commentsubject="<span id='wpSummaryLabel'><label for='wpSummary'>{$subject}:</label></span> <div class='editOptions'><input tabindex='1' type='text' value=\"$summarytext\" name='wpSummary' id='wpSummary' maxlength='200' size='60' /><br />";
 931+ $commentsubject="<span id='wpSummaryLabel'><label for='wpSummary'>{$subject}:</label></span>\n<div class='editOptions'>\n<input tabindex='1' type='text' value=\"$summarytext\" name='wpSummary' id='wpSummary' maxlength='200' size='60' /><br />";
932932 $editsummary = '';
933933 } else {
934934 $commentsubject = '';
935 - $editsummary="<span id='wpSummaryLabel'><label for='wpSummary'>{$summary}:</label></span> <div class='editOptions'><input tabindex='2' type='text' value=\"$summarytext\" name='wpSummary' id='wpSummary' maxlength='200' size='60' /><br />";
 935+ $editsummary="<span id='wpSummaryLabel'><label for='wpSummary'>{$summary}:</label></span>\n<div class='editOptions'>\n<input tabindex='2' type='text' value=\"$summarytext\" name='wpSummary' id='wpSummary' maxlength='200' size='60' /><br />";
936936 }
937937
938938 # Set focus to the edit box on load, except on preview or diff, where it would interfere with the display
@@ -1066,8 +1066,8 @@
10671067 {$safemodehtml}
10681068 ");
10691069
1070 - $wgOut->addHTML("
1071 -<div class='editButtons'>
 1070+ $wgOut->addHTML(
 1071+"<div class='editButtons'>
10721072 {$buttons['save']}
10731073 {$buttons['preview']}
10741074 {$buttons['live']}
Index: trunk/phase3/RELEASE-NOTES
@@ -301,6 +301,7 @@
302302 * (bug 6017) Update list of bookstores in German localisation files
303303 * (bug 5187) Allow programmatically bypassing username validation, for scripts
304304 * (bug 6025) SpecialImport: wrong message when no file selected
 305+* (bug 6015) EditPage: add spacing in the boxes "edit is minor" and "watch this"
305306
306307 == Compatibility ==
307308

Follow-up revisions

RevisionCommit summaryAuthorDate
r14307Backport from trunk r14306:...hashar08:09, 20 May 2006

Status & tagging log