r14307 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r14306‎ | r14307 | r14308 >
Date:08:09, 20 May 2006
Author:hashar
Status:old
Tags:
Comment:
Backport from trunk r14306:
Fix #6015: dd spacing in the boxes "edit is minor" and "watch this"
Patch by Rotem Liss <mail@rotemliss.com>
Modified paths:
  • /branches/REL1_6/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_6/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: branches/REL1_6/phase3/includes/EditPage.php
@@ -868,8 +868,8 @@
869869 if ( $wgUser->isAllowed('minoredit') ) {
870870 $minoredithtml =
871871 "<input tabindex='3' type='checkbox' value='1' name='wpMinoredit'".($this->minoredit?" checked='checked'":"").
872 - " accesskey='".wfMsg('accesskey-minoredit')."' id='wpMinoredit' />".
873 - "<label for='wpMinoredit' title='".wfMsg('tooltip-minoredit')."'>{$minor}</label>";
 872+ " accesskey='".wfMsg('accesskey-minoredit')."' id='wpMinoredit' />\n".
 873+ "<label for='wpMinoredit' title='".wfMsg('tooltip-minoredit')."'>{$minor}</label>\n";
874874 }
875875
876876 $watchhtml = '';
@@ -877,9 +877,9 @@
878878 if ( $wgUser->isLoggedIn() ) {
879879 $watchhtml = "<input tabindex='4' type='checkbox' name='wpWatchthis'".
880880 ($this->watchthis?" checked='checked'":"").
881 - " accesskey=\"".htmlspecialchars(wfMsg('accesskey-watch'))."\" id='wpWatchthis' />".
 881+ " accesskey=\"".htmlspecialchars(wfMsg('accesskey-watch'))."\" id='wpWatchthis' />\n".
882882 "<label for='wpWatchthis' title=\"" .
883 - htmlspecialchars(wfMsg('tooltip-watch'))."\">{$watchthis}</label>";
 883+ htmlspecialchars(wfMsg('tooltip-watch'))."\">{$watchthis}</label>\n";
884884 }
885885
886886 $checkboxhtml = $minoredithtml . $watchhtml;
@@ -902,11 +902,11 @@
903903 # Otherwise, show a summary field at the bottom
904904 $summarytext = htmlspecialchars( $wgContLang->recodeForEdit( $this->summary ) ); # FIXME
905905 if( $this->section == 'new' ) {
906 - $commentsubject="<span id='wpSummaryLabel'><label for='wpSummary'>{$subject}:</label></span> <div class='editOptions'><input tabindex='1' type='text' value=\"$summarytext\" name='wpSummary' id='wpSummary' maxlength='200' size='60' /><br />";
 906+ $commentsubject="<span id='wpSummaryLabel'><label for='wpSummary'>{$subject}:</label></span>\n<div class='editOptions'>\n<input tabindex='1' type='text' value=\"$summarytext\" name='wpSummary' id='wpSummary' maxlength='200' size='60' /><br />";
907907 $editsummary = '';
908908 } else {
909909 $commentsubject = '';
910 - $editsummary="<span id='wpSummaryLabel'><label for='wpSummary'>{$summary}:</label></span> <div class='editOptions'><input tabindex='2' type='text' value=\"$summarytext\" name='wpSummary' id='wpSummary' maxlength='200' size='60' /><br />";
 910+ $editsummary="<span id='wpSummaryLabel'><label for='wpSummary'>{$summary}:</label></span>\n<div class='editOptions'>\n<input tabindex='2' type='text' value=\"$summarytext\" name='wpSummary' id='wpSummary' maxlength='200' size='60' /><br />";
911911 }
912912
913913 # Set focus to the edit box on load, except on preview or diff, where it would interfere with the display
@@ -1042,8 +1042,8 @@
10431043 {$safemodehtml}
10441044 ");
10451045
1046 - $wgOut->addHTML("
1047 -<div class='editButtons'>
 1046+ $wgOut->addHTML(
 1047+"<div class='editButtons'>
10481048 {$buttons['save']}
10491049 {$buttons['preview']}
10501050 {$buttons['live']}
Index: branches/REL1_6/phase3/RELEASE-NOTES
@@ -11,6 +11,7 @@
1212 * (bug 5586) <gallery> treated text as links
1313 * (bug 5957) Update for Hebrew language (he)
1414 * (bug 6025) SpecialImport: wrong message when no file selected
 15+* (bug 6015) EditPage: add spacing in the boxes "edit is minor" and "watch this"
1516
1617 == MediaWiki 1.6.5 ==
1718

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r14306Fix #6015: dd spacing in the boxes "edit is minor" and "watch this"...hashar08:07, 20 May 2006

Status & tagging log