r14305 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r14304‎ | r14305 | r14306 >
Date:07:40, 20 May 2006
Author:hashar
Status:old
Tags:
Comment:
Backport from trunk r14304:
Fix #6025: SpecialImport.php -> wrong message when no file was selected
Patch by Jimmy Collins <jimmy.collins@web.de>
Modified paths:
  • /branches/REL1_6/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_6/phase3/includes/SpecialImport.php (modified) (history)

Diff [purge]

Index: branches/REL1_6/phase3/includes/SpecialImport.php
@@ -601,7 +601,7 @@
602602 function newFromUpload( $fieldname = "xmlimport" ) {
603603 $upload =& $_FILES[$fieldname];
604604
605 - if( !isset( $upload ) ) {
 605+ if( !isset( $upload ) || !$upload['name'] ) {
606606 return new WikiErrorMsg( 'importnofile' );
607607 }
608608 if( !empty( $upload['error'] ) ) {
Index: branches/REL1_6/phase3/RELEASE-NOTES
@@ -10,6 +10,7 @@
1111 * (bug 5857, 5957) Update for German localisation (de)
1212 * (bug 5586) <gallery> treated text as links
1313 * (bug 5957) Update for Hebrew language (he)
 14+* (bug 6025) SpecialImport: wrong message when no file selected
1415
1516 == MediaWiki 1.6.5 ==
1617

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r14304Fix #6025: SpecialImport.php -> wrong message when no file was selected...hashar07:37, 20 May 2006

Status & tagging log