r11578 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r11577‎ | r11578 | r11579 >
Date:01:30, 30 October 2005
Author:vibber
Status:old
Tags:
Comment:
* (bug 2885) Remove unnecessary reference parameter which broke classic skin
talk notification on PHP 5.0.5
Modified paths:
  • /branches/REL1_5/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_5/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: branches/REL1_5/phase3/includes/Title.php
@@ -2043,7 +2043,7 @@
20442044 * @param Title $title
20452045 * @return bool
20462046 */
2047 - function equals( &$title ) {
 2047+ function equals( $title ) {
20482048 return $this->getInterwiki() == $title->getInterwiki()
20492049 && $this->getNamespace() == $title->getNamespace()
20502050 && $this->getDbkey() == $title->getDbkey();
Index: branches/REL1_5/phase3/RELEASE-NOTES
@@ -882,6 +882,8 @@
883883 * (bug 3649) Remove obsolete, broken moveCustomMessages script
884884 * (bug 3667) Add missing global in page move code
885885 * (bug 3761) Avoid deprecation warnings in Special:Import
 886+* (bug 2885) Remove unnecessary reference parameter which broke classic skin
 887+ talk notification on PHP 5.0.5
886888
887889
888890 === Caveats ===

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r10239* (bug 2885) Fix fatal errors and notices in PHP 5.1.0beta3...vibber11:29, 22 July 2005
r10316* (bug 2885, 2931) Problems with references in php 4.4 and 5.1avar19:47, 30 July 2005
r10514* New special page: SpecialMostlinked...avar02:59, 15 August 2005
r10516* New special page: SpecialMostlinked...avar03:04, 15 August 2005
r10521* (bug 2885, 2931) Bah, bugs with the thingalabong 4.4.0, 5.1 eep!avar12:07, 15 August 2005
r10819* (bug 2885) More PHP 5.1 fixes: skin, search, log, undeletevibber21:58, 28 August 2005
r10820* (bug 2885) More PHP 5.1 fixes: skin, search, log, undeletevibber21:59, 28 August 2005
r11577* (bug 2885) Remove unnecessary reference parameter which broke classic skin...vibber01:30, 30 October 2005

Status & tagging log