r10521 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r10520‎ | r10521 | r10522 >
Date:12:07, 15 August 2005
Author:avar
Status:old
Tags:
Comment:
* (bug 2885, 2931) Bah, bugs with the thingalabong 4.4.0, 5.1 eep!
Modified paths:
  • /trunk/phase3/maintenance/parserTests.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/parserTests.inc
@@ -219,7 +219,7 @@
220220 $this->setupGlobals($opts);
221221
222222 $user =& new User();
223 - $options =& ParserOptions::newFromUser( $user );
 223+ $options = ParserOptions::newFromUser( $user );
224224
225225 if (preg_match('/\\bmath\\b/i', $opts)) {
226226 # XXX this should probably be done by the ParserOptions
@@ -243,7 +243,7 @@
244244 } elseif (preg_match('/\\bmsg\\b/i', $opts)) {
245245 $out = $parser->transformMsg( $input, $options );
246246 } else {
247 - $output =& $parser->parse( $input, $title, $options );
 247+ $output = $parser->parse( $input, $title, $options );
248248 $out = $output->getText();
249249
250250 if (preg_match('/\\bill\\b/i', $opts)) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r10819* (bug 2885) More PHP 5.1 fixes: skin, search, log, undeletevibber21:58, 28 August 2005
r10820* (bug 2885) More PHP 5.1 fixes: skin, search, log, undeletevibber21:59, 28 August 2005
r11577* (bug 2885) Remove unnecessary reference parameter which broke classic skin...vibber01:30, 30 October 2005
r11578* (bug 2885) Remove unnecessary reference parameter which broke classic skin...vibber01:30, 30 October 2005

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r10239* (bug 2885) Fix fatal errors and notices in PHP 5.1.0beta3...vibber11:29, 22 July 2005
r10316* (bug 2885, 2931) Problems with references in php 4.4 and 5.1avar19:47, 30 July 2005
r10514* New special page: SpecialMostlinked...avar02:59, 15 August 2005
r10516* New special page: SpecialMostlinked...avar03:04, 15 August 2005

Status & tagging log