r10819 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r10818‎ | r10819 | r10820 >
Date:21:58, 28 August 2005
Author:vibber
Status:old
Tags:
Comment:
* (bug 2885) More PHP 5.1 fixes: skin, search, log, undelete
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Database.php (modified) (history)
  • /trunk/phase3/includes/SkinTemplate.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SkinTemplate.php
@@ -225,7 +225,7 @@
226226 $tpl->setRef( 'jsmimetype', $wgJsMimeType );
227227 $tpl->setRef( 'charset', $wgOutputEncoding );
228228 $tpl->set( 'headlinks', $out->getHeadLinks() );
229 - $tpl->setRef('headscripts', $out->getScript() );
 229+ $tpl->set('headscripts', $out->getScript() );
230230 $tpl->setRef( 'wgScript', $wgScript );
231231 $tpl->setRef( 'skinname', $this->skinname );
232232 $tpl->setRef( 'stylename', $this->stylename );
Index: trunk/phase3/includes/Database.php
@@ -1522,7 +1522,7 @@
15231523 /**
15241524 * @todo document
15251525 */
1526 - function resultObject( &$result ) {
 1526+ function resultObject( $result ) {
15271527 if( empty( $result ) ) {
15281528 return NULL;
15291529 } else {
Index: trunk/phase3/RELEASE-NOTES
@@ -68,8 +68,8 @@
6969 * (bug 3284) Ipblocklist paging, substring search
7070 * Allow filtering of robot edits in Special:Watchlist by stting
7171 $wgFilterRobotsWL = true.
 72+* (bug 2885) More PHP 5.1 fixes: skin, search, log, undelete
7273
73 ->>>>>>> 1.394
7474
7575 === Caveats ===
7676

Follow-up revisions

RevisionCommit summaryAuthorDate
r10820* (bug 2885) More PHP 5.1 fixes: skin, search, log, undeletevibber21:59, 28 August 2005
r11577* (bug 2885) Remove unnecessary reference parameter which broke classic skin...vibber01:30, 30 October 2005
r11578* (bug 2885) Remove unnecessary reference parameter which broke classic skin...vibber01:30, 30 October 2005

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r10239* (bug 2885) Fix fatal errors and notices in PHP 5.1.0beta3...vibber11:29, 22 July 2005
r10316* (bug 2885, 2931) Problems with references in php 4.4 and 5.1avar19:47, 30 July 2005
r10514* New special page: SpecialMostlinked...avar02:59, 15 August 2005
r10516* New special page: SpecialMostlinked...avar03:04, 15 August 2005
r10521* (bug 2885, 2931) Bah, bugs with the thingalabong 4.4.0, 5.1 eep!avar12:07, 15 August 2005

Status & tagging log