r11577 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r11576‎ | r11577 | r11578 >
Date:01:30, 30 October 2005
Author:vibber
Status:old
Tags:
Comment:
* (bug 2885) Remove unnecessary reference parameter which broke classic skin
talk notification on PHP 5.0.5
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
@@ -1993,7 +1993,7 @@
19941994 * @param Title $title
19951995 * @return bool
19961996 */
1997 - function equals( &$title ) {
 1997+ function equals( $title ) {
19981998 return $this->getInterwiki() == $title->getInterwiki()
19991999 && $this->getNamespace() == $title->getNamespace()
20002000 && $this->getDbkey() == $title->getDbkey();
Index: trunk/phase3/RELEASE-NOTES
@@ -193,6 +193,8 @@
194194 * Ability to set the table name for external storage servers
195195 * (bug 3667) Add missing global in page move code
196196 * (bug 3761) Avoid deprecation warnings in Special:Import
 197+* (bug 2885) Remove unnecessary reference parameter which broke classic skin
 198+ talk notification on PHP 5.0.5
197199
198200
199201 === Caveats ===

Follow-up revisions

RevisionCommit summaryAuthorDate
r11578* (bug 2885) Remove unnecessary reference parameter which broke classic skin...vibber01:30, 30 October 2005

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r10239* (bug 2885) Fix fatal errors and notices in PHP 5.1.0beta3...vibber11:29, 22 July 2005
r10316* (bug 2885, 2931) Problems with references in php 4.4 and 5.1avar19:47, 30 July 2005
r10514* New special page: SpecialMostlinked...avar02:59, 15 August 2005
r10516* New special page: SpecialMostlinked...avar03:04, 15 August 2005
r10521* (bug 2885, 2931) Bah, bugs with the thingalabong 4.4.0, 5.1 eep!avar12:07, 15 August 2005
r10819* (bug 2885) More PHP 5.1 fixes: skin, search, log, undeletevibber21:58, 28 August 2005
r10820* (bug 2885) More PHP 5.1 fixes: skin, search, log, undeletevibber21:59, 28 August 2005

Status & tagging log