r114085 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r114084‎ | r114085 | r114086 >
Date:22:39, 17 March 2012
Author:catrope
Status:deferred (Comments)
Tags:
Comment:
Add a temporary disclaimer text making it clear that this is a prototype. Requested by Fabrice
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/SpecialArticleFeedbackv5.php (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.css (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php
@@ -145,6 +145,7 @@
146146 'articlefeedbackv5-mask-text-hidden' => 'This post was hidden by an authorized editor',
147147 'articlefeedbackv5-mask-text-oversight' => 'This post was oversighted by an authorized editor',
148148 'articlefeedbackv5-mask-postnumber' => 'Post #$1',
 149+ 'articlefeedbackv5-special-disclaimer' => 'This is a prototype. Please do not use it unless you have been invited to.',
149150
150151 /* Special page flyover panels */
151152 /* Hide this post panel */
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.css
@@ -19,6 +19,11 @@
2020 top: 1.3em;
2121 left: 3em;
2222 }
 23+.articlefeedbackv5-special-disclaimer {
 24+ font-size: 1.125em;
 25+ color: red;
 26+ font-weight: bold;
 27+}
2328 #articleFeedbackv5-header-wrap {
2429 margin: 0 0 10px;
2530 }
Index: trunk/extensions/ArticleFeedbackv5/SpecialArticleFeedbackv5.php
@@ -190,6 +190,13 @@
191191 ), $this->msg( 'articlefeedbackv5-beta-notice' )->text() )
192192 . Html::element( 'div', array( 'class' => 'float-clear' ) )
193193 );
 194+
 195+ // Temporary "This is a prototype" disclaimer text
 196+ $out->addHTML(
 197+ Html::element( 'div', array(
 198+ 'class' => 'articlefeedbackv5-special-disclaimer'
 199+ ), $this->msg( 'articlefeedbackv5-special-disclaimer' )->text() )
 200+ );
194201
195202 $out->addHtml(
196203 Html::element(

Follow-up revisions

RevisionCommit summaryAuthorDate
r1140871.19wmf1: MFT r114085catrope22:50, 17 March 2012
r114210Followup r114085: add message documentationcatrope23:14, 19 March 2012

Comments

#Comment by Nikerabbit (talk | contribs)   07:53, 19 March 2012

Please add message documentation for the newly added messages. Thanks.

Status & tagging log