r113988 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113987‎ | r113988 | r113989 >
Date:01:27, 16 March 2012
Author:reedy
Status:reverted
Tags:gerritmigration 
Comment:
Reports of undefined index notices related to display title

Add a isset precursor
Modified paths:
  • /trunk/extensions/Collection/Collection.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Collection/Collection.body.php
@@ -895,14 +895,14 @@
896896 } elseif ( $item['type'] == 'article' ) {
897897 if ( $item['currentVersion'] == 1 ) {
898898 $articleText .= ":[[" . $item['title'];
899 - if ( $item['displaytitle'] ) {
 899+ if ( isset( $item['displaytitle'] ) && $item['displaytitle'] ) {
900900 $articleText .= "|" . $item['displaytitle'];
901901 }
902902 $articleText .= "]]\n";
903903 } else {
904904 $articleText .= ":[{{fullurl:" . $item['title'];
905905 $articleText .= "|oldid=" . $item['revision'] . "}} ";
906 - if ( $item['displaytitle'] ) {
 906+ if ( isset( $item['displaytitle'] ) && $item['displaytitle'] ) {
907907 $articleText .= $item['displaytitle'];
908908 } else {
909909 $articleText .= $item['title'];

Follow-up revisions

RevisionCommit summaryAuthorDate
r113989MFT r113988 x3reedy01:32, 16 March 2012
r114399Revert r113740 and its followups r113785, r113985, r113986, r113988, r113991,...catrope19:56, 21 March 2012

Status & tagging log