r113989 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113988‎ | r113989 | r113990 >
Date:01:32, 16 March 2012
Author:reedy
Status:ok
Tags:
Comment:
MFT r113988 x3
Modified paths:
  • /branches/REL1_18/extensions/Collection (modified) (history)
  • /branches/REL1_18/extensions/Collection/Collection.body.php (modified) (history)
  • /branches/REL1_19/extensions/Collection (modified) (history)
  • /branches/REL1_19/extensions/Collection/Collection.body.php (modified) (history)
  • /branches/wmf/1.19wmf1/extensions/Collection (modified) (history)
  • /branches/wmf/1.19wmf1/extensions/Collection/Collection.body.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.19wmf1/extensions/Collection/Collection.body.php
@@ -835,14 +835,14 @@
836836 } elseif ( $item['type'] == 'article' ) {
837837 if ( $item['currentVersion'] == 1 ) {
838838 $articleText .= ":[[" . $item['title'];
839 - if ( $item['displaytitle'] ) {
 839+ if ( isset( $item['displaytitle'] ) && $item['displaytitle'] ) {
840840 $articleText .= "|" . $item['displaytitle'];
841841 }
842842 $articleText .= "]]\n";
843843 } else {
844844 $articleText .= ":[{{fullurl:" . $item['title'];
845845 $articleText .= "|oldid=" . $item['revision'] . "}} ";
846 - if ( $item['displaytitle'] ) {
 846+ if ( isset( $item['displaytitle'] ) && $item['displaytitle'] ) {
847847 $articleText .= $item['displaytitle'];
848848 } else {
849849 $articleText .= $item['title'];
Property changes on: branches/wmf/1.19wmf1/extensions/Collection/Collection.body.php
___________________________________________________________________
Modified: svn:mergeinfo
850850 Merged /trunk/extensions/Collection/Collection.body.php:r113988
Property changes on: branches/wmf/1.19wmf1/extensions/Collection
___________________________________________________________________
Modified: svn:mergeinfo
851851 Merged /trunk/extensions/Collection:r113988
Index: branches/REL1_18/extensions/Collection/Collection.body.php
@@ -831,14 +831,14 @@
832832 } elseif ( $item['type'] == 'article' ) {
833833 if ( $item['currentVersion'] == 1 ) {
834834 $articleText .= ":[[" . $item['title'];
835 - if ( $item['displaytitle'] ) {
 835+ if ( isset( $item['displaytitle'] ) && $item['displaytitle'] ) {
836836 $articleText .= "|" . $item['displaytitle'];
837837 }
838838 $articleText .= "]]\n";
839839 } else {
840840 $articleText .= ":[{{fullurl:" . $item['title'];
841841 $articleText .= "|oldid=" . $item['revision'] . "}} ";
842 - if ( $item['displaytitle'] ) {
 842+ if ( isset( $item['displaytitle'] ) && $item['displaytitle'] ) {
843843 $articleText .= $item['displaytitle'];
844844 } else {
845845 $articleText .= $item['title'];
Property changes on: branches/REL1_18/extensions/Collection
___________________________________________________________________
Modified: svn:mergeinfo
846846 Merged /trunk/extensions/Collection:r113988
Index: branches/REL1_19/extensions/Collection/Collection.body.php
@@ -831,14 +831,14 @@
832832 } elseif ( $item['type'] == 'article' ) {
833833 if ( $item['currentVersion'] == 1 ) {
834834 $articleText .= ":[[" . $item['title'];
835 - if ( $item['displaytitle'] ) {
 835+ if ( isset( $item['displaytitle'] ) && $item['displaytitle'] ) {
836836 $articleText .= "|" . $item['displaytitle'];
837837 }
838838 $articleText .= "]]\n";
839839 } else {
840840 $articleText .= ":[{{fullurl:" . $item['title'];
841841 $articleText .= "|oldid=" . $item['revision'] . "}} ";
842 - if ( $item['displaytitle'] ) {
 842+ if ( isset( $item['displaytitle'] ) && $item['displaytitle'] ) {
843843 $articleText .= $item['displaytitle'];
844844 } else {
845845 $articleText .= $item['title'];
Property changes on: branches/REL1_19/extensions/Collection
___________________________________________________________________
Added: svn:mergeinfo
846846 Merged /trunk/extensions/Collection:r111011,111199,111218,111484,111575,111685,111713,111715,112074,112153,112160,112229,112248,112253,112260,112295,112517,112520,112524,112562,112660,112687,112751,112758,112770-112772,112775,112849,112851,112856,112859,112903,112925,112993,113988

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r113988Reports of undefined index notices related to display title...reedy01:27, 16 March 2012

Status & tagging log