r113985 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113984‎ | r113985 | r113986 >
Date:01:07, 16 March 2012
Author:reedy
Status:reverted
Tags:gerritmigration 
Comment:
Followup r113740

Fix PODpartners casing difference

Remove unused global and useless return at the same time
Modified paths:
  • /trunk/extensions/Collection/Collection.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Collection/Collection.body.php
@@ -27,7 +27,7 @@
2828 parent::__construct( "Book" );
2929 global $wgCollectionPODPartners;
3030 if ( $PODPartners ) {
31 - $this->mPODPartners = $PODpartners;
 31+ $this->mPODPartners = $PODPartners;
3232 } else {
3333 $this->mPODPartners = $wgCollectionPODPartners;
3434 }
@@ -38,7 +38,7 @@
3939 }
4040
4141 function execute( $par ) {
42 - global $wgOut, $wgRequest, $wgUser, $wgContLang, $wgCollectionMaxArticles;
 42+ global $wgOut, $wgRequest, $wgUser, $wgCollectionMaxArticles;
4343
4444 // support previous URLs (e.g. used in templates) which used the "$par" part
4545 // (i.e. subpages of the Special page)
@@ -296,7 +296,6 @@
297297 default:
298298 $wgOut->showErrorPage( 'coll-unknown_subpage_title', 'coll-unknown_subpage_text' );
299299 }
300 - return;
301300 }
302301
303302 function renderBookCreatorPage( $referer, $par ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r114399Revert r113740 and its followups r113785, r113985, r113986, r113988, r113991,...catrope19:56, 21 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r113740(bug 33536) Make a list of print on demand publishers configurable for Extens...saper18:15, 13 March 2012

Status & tagging log