r113718 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113717‎ | r113718 | r113719 >
Date:13:38, 13 March 2012
Author:emsmith
Status:ok
Tags:
Comment:
bug 35106 - missed spot still using the clicktracking javascript for click link building instead of the new articlefeedbackv5 version which adds "additional" information
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.js
@@ -33,7 +33,7 @@
3434 'articleFeedbackv5_ct_token': clickTrackingSession,
3535 'articleFeedbackv5_ct_event': event
3636 } );
37 - $(this).attr( 'href', $.trackActionURL( editUrl, event + '-click' ) );
 37+ $(this).attr( 'href', $.articleFeedbackv5.trackActionURL( editUrl, event + '-click' ) );
3838 } );
3939 }
4040

Follow-up revisions

RevisionCommit summaryAuthorDate
r113735bug 35106 - adding | and rev id after title to edit_success items being trackedemsmith17:30, 13 March 2012
r113858bug 35106 - adding | and rev id after rest of tracking itemsemsmith21:23, 14 March 2012
r113972Fix ClickTracking URLs for the edit links so the title is added to those toocatrope23:10, 15 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r113626bug 35106 - really two issues here - fix for part one - the api wants the par...emsmith16:00, 12 March 2012
r113628bug 35106 - fix for part two - had to implement our own trackActionURL which ...emsmith16:20, 12 March 2012

Status & tagging log