r113972 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113971‎ | r113972 | r113973 >
Date:23:10, 15 March 2012
Author:catrope
Status:ok (Comments)
Tags:
Comment:
Fix ClickTracking URLs for the edit links so the title is added to those too
Modified paths:
  • /branches/wmf/1.19wmf1/extensions/ArticleFeedbackv5/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.19wmf1/extensions/ArticleFeedbackv5/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.js
@@ -33,7 +33,7 @@
3434 'articleFeedbackv5_ct_token': clickTrackingSession,
3535 'articleFeedbackv5_ct_event': event
3636 } );
37 - $(this).attr( 'href', $.trackActionURL( editUrl, event + '-click' ) );
 37+ $(this).attr( 'href', $.articleFeedbackv5.trackActionURL( editUrl, event + '-click' ) );
3838 } );
3939 }
4040

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r113718bug 35106 - missed spot still using the clicktracking javascript for click li...emsmith13:38, 13 March 2012

Comments

#Comment by Catrope (talk | contribs)   23:20, 15 March 2012

This is essentially an MFT of r113718, which I didn't discover until after committing this.

Status & tagging log