r113735 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113734‎ | r113735 | r113736 >
Date:17:30, 13 March 2012
Author:emsmith
Status:resolved
Tags:
Comment:
bug 35106 - adding | and rev id after title to edit_success items being tracked
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php
@@ -442,7 +442,7 @@
443443 public static function trackEditSuccess( &$article, &$user, $text,
444444 $summary, $minoredit, $watchthis, $sectionanchor, &$flags,
445445 $revision, &$status, $baseRevId /*, &$redirect */ ) { // $redirect not passed in 1.18wmf1
446 - self::trackEvent( 'edit_success', $article->getTitle() );
 446+ self::trackEvent( 'edit_success', $article->getTitle() . '|' . $baseRevId );
447447 return true;
448448 }
449449

Follow-up revisions

RevisionCommit summaryAuthorDate
r113858bug 35106 - adding | and rev id after rest of tracking itemsemsmith21:23, 14 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r113626bug 35106 - really two issues here - fix for part one - the api wants the par...emsmith16:00, 12 March 2012
r113628bug 35106 - fix for part two - had to implement our own trackActionURL which ...emsmith16:20, 12 March 2012
r113718bug 35106 - missed spot still using the clicktracking javascript for click li...emsmith13:38, 13 March 2012

Status & tagging log