r113626 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r113625‎ | r113626 | r113627 >
Date:16:00, 12 March 2012
Author:emsmith
Status:ok
Tags:
Comment:
bug 35106 - really two issues here - fix for part one - the api wants the param "additional" not "info"
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php
——@@ -485,7 +485,7 @@
486486 'action' => 'clicktracking',
487487 'eventid' => $trackingId,
488488 'token' => $token,
489 - 'info' => $title->getText(),
 489+ 'additional' => $title->getText(),
490490 'namespacenumber' => $title->getNamespace()
491491 ) );
492492 $api = new ApiMain( $params, true );

Follow-up revisions

RevisionCommit summaryAuthorDate
r113628bug 35106 - fix for part two - had to implement our own trackActionURL which ...emsmith16:20, 12 March 2012
r1136711.19wmf1: MFT r113626, r113628catrope21:37, 12 March 2012
r113718bug 35106 - missed spot still using the clicktracking javascript for click li...emsmith13:38, 13 March 2012
r113735bug 35106 - adding | and rev id after title to edit_success items being trackedemsmith17:30, 13 March 2012
r113858bug 35106 - adding | and rev id after rest of tracking itemsemsmith21:23, 14 March 2012

Status & tagging log