r113287 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113286‎ | r113287 | r113288 >
Date:20:22, 7 March 2012
Author:emsmith
Status:ok (Comments)
Tags:i18nreview, todo 
Comment:
bug 34090 - usernames and formatted timestamps into red lines for hidden/oversighted both on page load and dynamic hide/oversight (uses the data-blah custom attribute trick with jquery)
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/api/ApiFlagFeedbackArticleFeedbackv5.php (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/api/ApiViewFeedbackArticleFeedbackv5.php (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php
@@ -81,8 +81,8 @@
8282 'articlefeedbackv5-special-more' => 'Show more posts',
8383 'articlefeedbackv5-special-pagetitle' => 'Feedback: $1',
8484 'articlefeedbackv5-form-optionid' => 'Option $1',
85 - 'articlefeedbackv5-hidden' => 'This post was hidden by an authorized editor',
86 - 'articlefeedbackv5-deleted' => 'This post was deleted by oversighters',
 85+ 'articlefeedbackv5-hidden' => 'This post was hidden by $1 on $2',
 86+ 'articlefeedbackv5-deleted' => 'This post was deleted by $1 on $2',
8787 'articlefeedbackv5-form-hide' => 'Hide this post',
8888 'articlefeedbackv5-form-unhide' => 'Unhide this post',
8989 'articlefeedbackv5-form-helpful' => 'Mark as helpful ($1)',
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js
@@ -476,7 +476,7 @@
477477 $row.addClass( 'articleFeedbackv5-feedback-hidden' )
478478 .data( 'hidden', true );
479479 $( '<span class="articleFeedbackv5-feedback-hidden-marker"></span>' )
480 - .text( mw.msg( 'articlefeedbackv5-hidden' ) )
 480+ .text( mw.msg( 'articlefeedbackv5-hidden', $row.data('hide-user'), $row.data('hide-timestamp')) )
481481 .insertBefore( $row.find( '.articleFeedbackv5-comment-wrap h3' ) );
482482 $.articleFeedbackv5special.maskPost( $row );
483483 };
@@ -523,7 +523,7 @@
524524 $row.addClass( 'articleFeedbackv5-feedback-deleted' )
525525 .data( 'deleted', true );
526526 var $marker = $( '<span class="articleFeedbackv5-feedback-deleted-marker"></span>' )
527 - .text( mw.msg( 'articlefeedbackv5-deleted' ) )
 527+ .text( mw.msg( 'articlefeedbackv5-deleted', $row.data('oversight-user'), $row.data('oversight-timestamp') ) )
528528 .insertBefore( $row.find( '.articleFeedbackv5-comment-wrap h3' ) );
529529 $.articleFeedbackv5special.maskPost( $row );
530530 };
@@ -1033,6 +1033,10 @@
10341034 .text( mw.msg( 'articlefeedbackv5-form-unhide' ) )
10351035 .removeClass( 'articleFeedbackv5-hide-link' )
10361036 .addClass( 'articleFeedbackv5-show-link' );
 1037+
 1038+ $link.data( 'hide-user', data['articlefeedbackv5-flag-feedback']['hide-user']);
 1039+ $link.data( 'hide-timestamp', data['articlefeedbackv5-flag-feedback']['hide-timestamp']);
 1040+
10371041 $.articleFeedbackv5special.markHidden( $link.closest( '.articleFeedbackv5-feedback' ) );
10381042 $.articleFeedbackv5special.setActivityFlag( id, 'hide', true );
10391043 }
@@ -1108,6 +1112,10 @@
11091113 .text( mw.msg( 'articlefeedbackv5-form-undelete' ) )
11101114 .removeClass( 'articleFeedbackv5-oversight-link' )
11111115 .addClass( 'articleFeedbackv5-unoversight-link' );
 1116+
 1117+ $link.data( 'oversight-user', data['articlefeedbackv5-flag-feedback']['oversight-user']);
 1118+ $link.data( 'oversight-timestamp', data['articlefeedbackv5-flag-feedback']['oversight-timestamp']);
 1119+
11121120 $.articleFeedbackv5special.markDeleted( $link.closest( '.articleFeedbackv5-feedback' ) );
11131121 $.articleFeedbackv5special.setActivityFlag( id, 'delete', true );
11141122 }
Index: trunk/extensions/ArticleFeedbackv5/api/ApiFlagFeedbackArticleFeedbackv5.php
@@ -82,9 +82,9 @@
8383 $filters['undeleted'] = -1;
8484 }
8585
86 - // TODO: This is data for the "hidden by, oversighted by" red line
87 - $results['oversight_user'] = $wgUser->getId();
88 - $results['oversight_timestamp'] = $timestamp;
 86+ // This is data for the "hidden by, oversighted by" red line
 87+ $results['oversight-user'] = $wgUser->getName();
 88+ $results['oversight-timestamp'] = wfTimestamp( TS_RFC2822, $timestamp );
8989
9090 // autohide if not hidden
9191 if (false == $record->af_is_hidden ) {
@@ -97,9 +97,9 @@
9898 $implicit_hide = true; // for logging
9999 // tell front-end autohiding was done
100100 $results['autohidden'] = 1;
101 - // TODO: This is data for the "hidden by, oversighted by" red line
102 - $results['hide_user'] = 0;
103 - $results['hide_timestamp'] = $timestamp;
 101+ // This is data for the "hidden by, oversighted by" red line
 102+ $results['hide-user'] = 'Article Feedback V5';
 103+ $results['hide-timestamp'] = wfTimestamp( TS_RFC2822, $timestamp );
104104 }
105105
106106 } else {
@@ -129,9 +129,9 @@
130130 $update['af_hide_timestamp'] = $timestamp;
131131 $filters = $this->changeFilterCounts( $record, $filters, 'hide' );
132132
133 - // TODO: This is data for the "hidden by, oversighted by" red line
134 - $results['hide_user'] = $wgUser->getId();
135 - $results['hide_timestamp'] = $timestamp;
 133+ // This is data for the "hidden by, oversighted by" red line
 134+ $results['hide-user'] = $wgUser->getName();
 135+ $results['hide-timestamp'] = wfTimestamp( TS_RFC2822, $timestamp );
136136
137137 } else {
138138 // decrease means "unhide this"
@@ -201,9 +201,9 @@
202202
203203 // tell front-end autohiding was done
204204 $results['autohidden'] = 1;
205 - // TODO: This is data for the "hidden by, oversighted by" red line
206 - $results['hide_user'] = 0;
207 - $results['hide_timestamp'] = $timestamp;
 205+ // This is data for the "hidden by, oversighted by" red line
 206+ $results['hide-user'] = 'Article Feedback V5';
 207+ $results['hide-timestamp'] = wfTimestamp( TS_RFC2822, $timestamp );
208208 }
209209 }
210210
@@ -249,9 +249,9 @@
250250 $implicit_hide = true; // for logging
251251 // tell front-end autohiding was done
252252 $results['autohidden'] = 1;
253 - // TODO: This is data for the "hidden by, oversighted by" red line
254 - $results['hide_user'] = 0;
255 - $results['hide_timestamp'] = $timestamp;
 253+ // This is data for the "hidden by, oversighted by" red line
 254+ $results['hide-user'] = 'Article Feedback V5';
 255+ $results['hide-timestamp'] = wfTimestamp( TS_RFC2822, $timestamp );
256256 }
257257
258258 // IF the previous setting was 0, send an email
Index: trunk/extensions/ArticleFeedbackv5/api/ApiViewFeedbackArticleFeedbackv5.php
@@ -508,9 +508,9 @@
509509 $name = 'Article Feedback V5';
510510 }
511511
512 - $attributes['hide_user'] = $name;
 512+ $attributes['data-hide-user'] = $name;
513513 if ($record[0]->af_hide_timestamp > 0) {
514 - $attributes['hide_timestamp'] = wfTimestamp( TS_RFC2822, $record[0]->af_hide_timestamp );
 514+ $attributes['data-hide-timestamp'] = wfTimestamp( TS_RFC2822, $record[0]->af_hide_timestamp );
515515 }
516516 }
517517 if ( $record[0]->af_is_deleted ) {
@@ -525,9 +525,9 @@
526526 $name = 'Article Feedback V5';
527527 }
528528
529 - $attributes['oversight_user'] = $name;
 529+ $attributes['data-oversight-user'] = $name;
530530 if ($record[0]->af_oversight_timestamp > 0) {
531 - $attributes['oversight_timestamp'] = wfTimestamp( TS_RFC2822, $record[0]->af_oversight_timestamp );
 531+ $attributes['data-oversight-timestamp'] = wfTimestamp( TS_RFC2822, $record[0]->af_oversight_timestamp );
532532 }
533533 }
534534

Follow-up revisions

RevisionCommit summaryAuthorDate
r113311bug 34090 - fixing the username bugs - apparently using the data- stuff with ...emsmith22:34, 7 March 2012
r113317bug 34090 - js and css voodoo to make the element with the red lines appear a...emsmith23:01, 7 March 2012
r113370bug 34090 - make different titles for masking appear if it's been hidden or o...emsmith16:43, 8 March 2012
r113371bug 34090 - fixes for oversighter view for hide/oversight panelsemsmith17:51, 8 March 2012
r113383bug 34090 - not entirely necessary, but keeps $2 from showing up in hiders pa...emsmith19:25, 8 March 2012
r113384bug 34090 - fix for double red line issues when hiding an oversighted post ha...emsmith19:28, 8 March 2012
r113390bug 34090 - adding translation for "automatic hider" useremsmith19:44, 8 March 2012
r113392bug 34090 - followup to r113287 - adjusted localization documentationemsmith20:03, 8 March 2012
r113393bug 34090 - followup to r113370 - adjusted localization documentationemsmith20:05, 8 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r111211bug 34090 - Added a log namespace and log types for the Article Feedback v5 e...emsmith22:53, 10 February 2012
r111472bug 34090 - Added an additional column in the main feedback table to keep a c...emsmith19:14, 14 February 2012
r111474bug 34090 - remove a todo - take the note from the flag submission and save i...emsmith19:57, 14 February 2012
r111552bug 34090 - split activity notes into their own config for maximum length (th...emsmith16:07, 15 February 2012
r111557bug 34090 - changed structure of the link classes and ids per the following f...emsmith16:47, 15 February 2012
r111570bug 34090 - request oversight is now a counter - so you can request/unrequest...emsmith19:53, 15 February 2012
r111573bug 34090 - removed the "header" portion of the html generation from the acti...emsmith20:18, 15 February 2012
r111645bug 34090 - updated the filter count update script to get requested oversight...emsmith15:45, 16 February 2012
r112038bug 34090 - added additional counts for filters including unhidden, undeleted...emsmith20:28, 21 February 2012
r112039bug 34090 - fixed issue noted : if $feedback is false return nothing - not th...emsmith20:50, 21 February 2012
r112041bug 34090 - kill the -1 issue by never letting it get below 0emsmith21:08, 21 February 2012
r112115bug 34090 - no code changes, just fixing/adding keyword svn propertiesemsmith16:31, 22 February 2012
r112119bug 34090 - cast the naughty column so it can be signed, the greatest still k...emsmith16:57, 22 February 2012
r112142bug 34090 - toggle for atomic un/helpful changing (and elimination of an extr...emsmith20:37, 22 February 2012
r112147bug 34090 - note to self, watch the copy and paste errors...emsmith21:01, 22 February 2012
r112149bug 34090 - no upper limit, only lower limit - we can't get any worse then 0emsmith21:21, 22 February 2012
r112154bug 34090 - quick and dirty helper script to get missing documentation keysemsmith21:57, 22 February 2012
r112156bug 34090 - only send the activity header if continue < 1, make the more div ...emsmith22:14, 22 February 2012
r112161bug 34090 - fix limit and use old continue to determine if we do the headeremsmith23:15, 22 February 2012
r112218bug 34090 - make sure the name are right for hidden/unhidden logging (argh)emsmith16:44, 23 February 2012
r112225bug 34090 - unhidden and unoversight logic adjustmentsemsmith18:06, 23 February 2012
r112228bug 34090 - fix filter - needsoversight are always autohiddenemsmith19:16, 23 February 2012
r112230bug 34090 - let's try this again - needsoversight and declined will have hidd...emsmith19:38, 23 February 2012
r112232bug 34090 - hide and show shouldn't fiddle with oversight counts or declined ...emsmith19:48, 23 February 2012
r112599bug 34090 - follow up to r111211 - rename things to make them "less confusin...emsmith14:43, 28 February 2012
r112603bug 34090 - Add the logging of automated hide/show errors by the "Article Fee...emsmith15:21, 28 February 2012
r112604bug 34090 - can't believe there were no permissions checks in this - only del...emsmith15:38, 28 February 2012
r112610bug 34090 - change all sql updates to use escaping except for explicitly comm...emsmith16:22, 28 February 2012
r112611bug 34090 - take out implicit show and add returning user that hid/oversighte...emsmith17:02, 28 February 2012
r112627bug 34090 - follow up to r112599 - change to use getText since it's going int...emsmith18:53, 28 February 2012
r112825bug 34090 - insert custom attributes (sigh) for the user and formatted timest...emsmith18:14, 1 March 2012
r112830bug 34090 - follow up to r111474 - use truncate for choppingemsmith19:42, 1 March 2012
r113052bug 34090 - remaining backend feature in requirements, oversight email genera...emsmith18:04, 5 March 2012
r113062bug 34090 - follow up to r110520 1. change index 2. default of null for conti...emsmith18:54, 5 March 2012
r113073bug 34090 - follow up to r111472 part 1 - change to use getDbKey, check for b...emsmith19:48, 5 March 2012
r113082bug 34090 - follow up to r111471 - changed to use text()emsmith20:42, 5 March 2012
r113083bug 34090 - follow up to rr111472 part 2 - only use log_id for orderingemsmith20:48, 5 March 2012
r113104bug 34090 - follow up to rr111472 part 3 - totally redo the continue function...emsmith23:10, 5 March 2012
r113159bug 34090 - follow up to rr111472 part 4 and follow up to r111596 (same issue...emsmith17:37, 6 March 2012
r113160bug 34090 - follow up to rr111472 part 5 plural and number format action countemsmith17:48, 6 March 2012
r113161bug 34090 - follow up to rr111472 part 6 last of lego messagesemsmith17:53, 6 March 2012
r113163bug 34090 - two additional configuration settings (help url and admin user ur...emsmith18:02, 6 March 2012
r113193bug 34090 - followup to r113104 - only sort by timestamp (sorting by log id w...emsmith22:56, 6 March 2012
r113228bug 34090 - followup to r113160emsmith14:05, 7 March 2012
r113247bug 34090 - db issue, remove one of the sorts from the query, use the ids arr...emsmith16:52, 7 March 2012
r113269bug 34090 - followup to r113247emsmith19:01, 7 March 2012
r113273bug 34090 - add javascript level hiding on request oversight IF autohidden is...emsmith19:22, 7 March 2012

Comments

#Comment by Nikerabbit (talk | contribs)   06:55, 8 March 2012

Please update the message documentation for the changed messages. Thanks.

#Comment by Catrope (talk | contribs)   18:15, 8 March 2012

Marking todo for message documentation and lack of i18n for the fake username.

#Comment by Nikerabbit (talk | contribs)   18:35, 8 March 2012

/me protests.

Status & tagging log