r112156 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112155‎ | r112156 | r112157 >
Date:22:14, 22 February 2012
Author:emsmith
Status:ok
Tags:
Comment:
bug 34090 - only send the activity header if continue < 1, make the more div a link
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/api/ApiViewActivityArticleFeedbackv5.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/api/ApiViewActivityArticleFeedbackv5.php
@@ -66,57 +66,60 @@
6767 // generate our html
6868 $html = '';
6969
70 - // <div class="articleFeedbackv5-activity-pane">
71 - $html .= Html::openElement( 'div', array(
72 - 'class' => 'articleFeedbackv5-activity-pane'
73 - ) );
 70+ // only do this if continue < 1
 71+ if ($continue < 1) {
 72+ // <div class="articleFeedbackv5-activity-pane">
 73+ $html .= Html::openElement( 'div', array(
 74+ 'class' => 'articleFeedbackv5-activity-pane'
 75+ ) );
 76+
 77+ // <div class="articleFeedbackv5-activity-feedback">
 78+ $html .= Html::openElement( 'div', array(
 79+ 'class' => 'articleFeedbackv5-activity-feedback'
 80+ ) );
 81+
 82+ // <div>Feedback Post #{$feedbackid} by {$user_link}</div>
 83+ $html .= Html::openElement( 'div', array() );
 84+ $html .= wfMessage( 'articlefeedbackv5-activity-feedback-info',
 85+ array($feedback->af_id))->text()
 86+ . $this->getUserLink($feedback->af_user_id, $feedback->af_user_ip);
 87+ $html .= Html::closeElement( 'div' );
 88+
 89+ //<div>Posted on {$date} (UTC)</div>
 90+ $html .= Html::element( 'div', array(),
 91+ wfMessage( 'articlefeedbackv5-activity-feedback-date',
 92+ array( $wgLang->timeanddate( $feedback->af_created ) ))->text() );
 93+
 94+ // <div class="articleFeedbackv5-activity-feedback-permalink">
 95+ $html .= Html::openElement( 'div', array(
 96+ 'class' => 'articleFeedbackv5-activity-feedback-permalink'
 97+ ) );
 98+
 99+ // <a href="{$permalink}">permalink</a>
 100+ $html .= Linker::link(
 101+ SpecialPage::getTitleFor( 'ArticleFeedbackv5', $title . '/'. $feedback->af_id ),
 102+ wfMessage( 'articlefeedbackv5-activity-permalink' )->text());
 103+
 104+ // </div> for class="articleFeedbackv5-activity-feedback-permalink"
 105+ $html .= Html::closeElement( 'div' );
 106+
 107+ // </div> for class="articleFeedbackv5-activity-feedback"
 108+ $html .= Html::closeElement( 'div' );
 109+
 110+ //<div class="articleFeedbackv5-activity-count">$n actions on this post</div>
 111+ $html .= Html::element( 'div', array('class' => 'articleFeedbackv5-activity-count'),
 112+ wfMessage( 'articlefeedbackv5-activity-count',
 113+ array( $feedback->af_activity_count ))->text() );
 114+
 115+ // </div> for class="articleFeedbackv5-activity-pane"
 116+ $html .= Html::closeElement( 'div' );
 117+
 118+ //<div class="articleFeedbackv5-activity-log-items">
 119+ $html .= Html::openElement( 'div', array(
 120+ 'class' => 'articleFeedbackv5-activity-log-items'
 121+ ) );
 122+ }
74123
75 - // <div class="articleFeedbackv5-activity-feedback">
76 - $html .= Html::openElement( 'div', array(
77 - 'class' => 'articleFeedbackv5-activity-feedback'
78 - ) );
79 -
80 - // <div>Feedback Post #{$feedbackid} by {$user_link}</div>
81 - $html .= Html::openElement( 'div', array() );
82 - $html .= wfMessage( 'articlefeedbackv5-activity-feedback-info',
83 - array($feedback->af_id))->text()
84 - . $this->getUserLink($feedback->af_user_id, $feedback->af_user_ip);
85 - $html .= Html::closeElement( 'div' );
86 -
87 - //<div>Posted on {$date} (UTC)</div>
88 - $html .= Html::element( 'div', array(),
89 - wfMessage( 'articlefeedbackv5-activity-feedback-date',
90 - array( $wgLang->timeanddate( $feedback->af_created ) ))->text() );
91 -
92 - // <div class="articleFeedbackv5-activity-feedback-permalink">
93 - $html .= Html::openElement( 'div', array(
94 - 'class' => 'articleFeedbackv5-activity-feedback-permalink'
95 - ) );
96 -
97 - // <a href="{$permalink}">permalink</a>
98 - $html .= Linker::link(
99 - SpecialPage::getTitleFor( 'ArticleFeedbackv5', $title . '/'. $feedback->af_id ),
100 - wfMessage( 'articlefeedbackv5-activity-permalink' )->text());
101 -
102 - // </div> for class="articleFeedbackv5-activity-feedback-permalink"
103 - $html .= Html::closeElement( 'div' );
104 -
105 - // </div> for class="articleFeedbackv5-activity-feedback"
106 - $html .= Html::closeElement( 'div' );
107 -
108 - //<div class="articleFeedbackv5-activity-count">$n actions on this post</div>
109 - $html .= Html::element( 'div', array('class' => 'articleFeedbackv5-activity-count'),
110 - wfMessage( 'articlefeedbackv5-activity-count',
111 - array( $feedback->af_activity_count ))->text() );
112 -
113 - // </div> for class="articleFeedbackv5-activity-pane"
114 - $html .= Html::closeElement( 'div' );
115 -
116 - //<div class="articleFeedbackv5-activity-log-items">
117 - $html .= Html::openElement( 'div', array(
118 - 'class' => 'articleFeedbackv5-activity-log-items'
119 - ) );
120 -
121124 // divs of activity items
122125 foreach($activities as $item) {
123126
@@ -156,10 +159,12 @@
157160 // figure out if we have more based on our new continue value
158161 $more = $this->fetchHasMore($title, $feedbackId, $continue);
159162
160 - //optional <div class="articleFeedbackv5-activity-more">Show more Activity</div>
 163+ //optional <a href="#" class="articleFeedbackv5-activity-more">Show more Activity</a>
161164 if ($more) {
162 - $html .= Html::element( 'div', array('class' => 'articleFeedbackv5-activity-more'),
163 - wfMessage( 'articlefeedbackv5-activity-more', array())->text() );
 165+ $html .= Html::element( 'a', array(
 166+ 'class' => "articleFeedbackv5-activity-more",
 167+ 'href' => '#',
 168+ ), wfMessage( "articlefeedbackv5-activity-more" )->text() );
164169 }
165170
166171 // </div> for class="acticleFeedbackv5-activity-log-items"

Follow-up revisions

RevisionCommit summaryAuthorDate
r112161bug 34090 - fix limit and use old continue to determine if we do the headeremsmith23:15, 22 February 2012
r112218bug 34090 - make sure the name are right for hidden/unhidden logging (argh)emsmith16:44, 23 February 2012
r112225bug 34090 - unhidden and unoversight logic adjustmentsemsmith18:06, 23 February 2012
r112228bug 34090 - fix filter - needsoversight are always autohiddenemsmith19:16, 23 February 2012
r112230bug 34090 - let's try this again - needsoversight and declined will have hidd...emsmith19:38, 23 February 2012
r112232bug 34090 - hide and show shouldn't fiddle with oversight counts or declined ...emsmith19:48, 23 February 2012
r112599bug 34090 - follow up to r111211 - rename things to make them "less confusin...emsmith14:43, 28 February 2012
r112603bug 34090 - Add the logging of automated hide/show errors by the "Article Fee...emsmith15:21, 28 February 2012
r112604bug 34090 - can't believe there were no permissions checks in this - only del...emsmith15:38, 28 February 2012
r112610bug 34090 - change all sql updates to use escaping except for explicitly comm...emsmith16:22, 28 February 2012
r112611bug 34090 - take out implicit show and add returning user that hid/oversighte...emsmith17:02, 28 February 2012
r112627bug 34090 - follow up to r112599 - change to use getText since it's going int...emsmith18:53, 28 February 2012
r112825bug 34090 - insert custom attributes (sigh) for the user and formatted timest...emsmith18:14, 1 March 2012
r112830bug 34090 - follow up to r111474 - use truncate for choppingemsmith19:42, 1 March 2012
r113052bug 34090 - remaining backend feature in requirements, oversight email genera...emsmith18:04, 5 March 2012
r113062bug 34090 - follow up to r110520 1. change index 2. default of null for conti...emsmith18:54, 5 March 2012
r113073bug 34090 - follow up to r111472 part 1 - change to use getDbKey, check for b...emsmith19:48, 5 March 2012
r113082bug 34090 - follow up to r111471 - changed to use text()emsmith20:42, 5 March 2012
r113083bug 34090 - follow up to rr111472 part 2 - only use log_id for orderingemsmith20:48, 5 March 2012
r113104bug 34090 - follow up to rr111472 part 3 - totally redo the continue function...emsmith23:10, 5 March 2012
r113159bug 34090 - follow up to rr111472 part 4 and follow up to r111596 (same issue...emsmith17:37, 6 March 2012
r113160bug 34090 - follow up to rr111472 part 5 plural and number format action countemsmith17:48, 6 March 2012
r113161bug 34090 - follow up to rr111472 part 6 last of lego messagesemsmith17:53, 6 March 2012
r113163bug 34090 - two additional configuration settings (help url and admin user ur...emsmith18:02, 6 March 2012
r113193bug 34090 - followup to r113104 - only sort by timestamp (sorting by log id w...emsmith22:56, 6 March 2012
r113228bug 34090 - followup to r113160emsmith14:05, 7 March 2012
r113247bug 34090 - db issue, remove one of the sorts from the query, use the ids arr...emsmith16:52, 7 March 2012
r113269bug 34090 - followup to r113247emsmith19:01, 7 March 2012
r113273bug 34090 - add javascript level hiding on request oversight IF autohidden is...emsmith19:22, 7 March 2012
r113287bug 34090 - usernames and formatted timestamps into red lines for hidden/over...emsmith20:22, 7 March 2012
r113311bug 34090 - fixing the username bugs - apparently using the data- stuff with ...emsmith22:34, 7 March 2012
r113317bug 34090 - js and css voodoo to make the element with the red lines appear a...emsmith23:01, 7 March 2012
r113370bug 34090 - make different titles for masking appear if it's been hidden or o...emsmith16:43, 8 March 2012
r113371bug 34090 - fixes for oversighter view for hide/oversight panelsemsmith17:51, 8 March 2012
r113383bug 34090 - not entirely necessary, but keeps $2 from showing up in hiders pa...emsmith19:25, 8 March 2012
r113384bug 34090 - fix for double red line issues when hiding an oversighted post ha...emsmith19:28, 8 March 2012
r113390bug 34090 - adding translation for "automatic hider" useremsmith19:44, 8 March 2012
r113392bug 34090 - followup to r113287 - adjusted localization documentationemsmith20:03, 8 March 2012
r113393bug 34090 - followup to r113370 - adjusted localization documentationemsmith20:05, 8 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r111211bug 34090 - Added a log namespace and log types for the Article Feedback v5 e...emsmith22:53, 10 February 2012
r111472bug 34090 - Added an additional column in the main feedback table to keep a c...emsmith19:14, 14 February 2012
r111474bug 34090 - remove a todo - take the note from the flag submission and save i...emsmith19:57, 14 February 2012
r111552bug 34090 - split activity notes into their own config for maximum length (th...emsmith16:07, 15 February 2012
r111557bug 34090 - changed structure of the link classes and ids per the following f...emsmith16:47, 15 February 2012
r111570bug 34090 - request oversight is now a counter - so you can request/unrequest...emsmith19:53, 15 February 2012
r111573bug 34090 - removed the "header" portion of the html generation from the acti...emsmith20:18, 15 February 2012
r111645bug 34090 - updated the filter count update script to get requested oversight...emsmith15:45, 16 February 2012
r112038bug 34090 - added additional counts for filters including unhidden, undeleted...emsmith20:28, 21 February 2012
r112039bug 34090 - fixed issue noted : if $feedback is false return nothing - not th...emsmith20:50, 21 February 2012
r112041bug 34090 - kill the -1 issue by never letting it get below 0emsmith21:08, 21 February 2012
r112115bug 34090 - no code changes, just fixing/adding keyword svn propertiesemsmith16:31, 22 February 2012
r112119bug 34090 - cast the naughty column so it can be signed, the greatest still k...emsmith16:57, 22 February 2012
r112142bug 34090 - toggle for atomic un/helpful changing (and elimination of an extr...emsmith20:37, 22 February 2012
r112147bug 34090 - note to self, watch the copy and paste errors...emsmith21:01, 22 February 2012
r112149bug 34090 - no upper limit, only lower limit - we can't get any worse then 0emsmith21:21, 22 February 2012
r112154bug 34090 - quick and dirty helper script to get missing documentation keysemsmith21:57, 22 February 2012

Status & tagging log