r113163 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113162‎ | r113163 | r113164 >
Date:18:02, 6 March 2012
Author:emsmith
Status:ok (Comments)
Tags:
Comment:
bug 34090 - two additional configuration settings (help url and admin user url) for use in oversight email, added settings to email formatting, changed email text
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.php (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5MailerJob.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php
@@ -387,26 +387,29 @@
388388 Best wishes, and thank you,
389389 The {{SITENAME}} team',
390390
391 - 'articlefeedbackv5-email-request-oversight-subject' => '$1 has requested oversight on $2',
392 - 'articlefeedbackv5-email-request-oversight-body' => 'Hello!
 391+ 'articlefeedbackv5-email-request-oversight-subject' => 'Oversight requested for article feedback page',
393392
394 -A request for oversight has been made by
 393+ 'articlefeedbackv5-email-request-oversight-body' => 'Hello, oversighters!
395394
396 -$4 : $1
 395+Oversight was requested by <user name - $4 : $1> for feedback posted on this article:
397396
398 -for page
 397+<Article title - $5 : $2>
399398
400 -$5 : $2
 399+Please review this feedback post, then approve or decline this oversight request:
401400
402 -Please visit feedback item
 401+<permalink of feedback post for which oversight was requested - $3>
403402
404 -$3
 403+If you have any questions about using the oversight features of the feedback page, please check this <oversighter feedback FAQ - $6> or contact community liaison <Oliver Keyes $7>.
405404
406 -to decline or approve this oversight request.
407 -
408405 Thank you,
409 -The {{SITENAME}} team',
410406
 407+
 408+The {{SITENAME}} Team
 409+
 410+
 411+P.S.: Please note that the article feedback feature v5 is still in early stages of testing on the English Encyclopedia (0.6%, or 22k articles) and that the feedback page has not been publicized to the community during this testing period.
 412+',
 413+
411414 );
412415
413416 /** Message documentation (Message documentation)
@@ -667,15 +670,15 @@
668671 * <code>$1</code> – URL of the confirmation link
669672 * <code>$2</code> – URL to type in the confirmation code manually.
670673 * <code>$3</code> – Confirmation code for the user to type in',
671 - 'articlefeedbackv5-email-request-oversight-subject' => 'Subject line for email sent to oversight mailing list when an oversight request has been made.
672 -* <code>$1</code> – User name of requestor
673 -* <code>$2</code> – Page name of item with feedback requiring oversight.',
 674+ 'articlefeedbackv5-email-request-oversight-subject' => 'Subject line for email sent to oversight mailing list when an oversight request has been made.',
674675 'articlefeedbackv5-email-request-oversight-body' => 'Body of an email sent to the oversight mailing list when an oversight request has been made.
675676 * <code>$1</code> – URL of user who requested oversight
676677 * <code>$2</code> – URL of page with feedback requiring oversight
677678 * <code>$3</code> – URL directly to feedback location
678679 * <code>$4</code> – User name of requestor
679 -* <code>$5</code> – Page name of item with feedback requiring oversight.',
 680+* <code>$5</code> – Page name of item with feedback requiring oversight.
 681+* <code>$6</code> – the help link.
 682+* <code>$7</code> – Oliver Keyes user page link.',
680683 );
681684
682685 /** Afrikaans (Afrikaans)
Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.php
@@ -15,12 +15,16 @@
1616 // Email address to send oversight request emails to, if set to null no emails are sent
1717 $wgArticleFeedbackv5OversightEmails = null;
1818
19 -// Should eventually be this, let's NOT flood that list with bogus emails
20 -// $wgArticleFeedbackv5OversightEmails = 'stewards@wikimedia.org';
21 -
2219 // Name to send oversight request emails to
2320 $wgArticleFeedbackv5OversightEmailName = 'Oversighters';
2421
 22+// Help link for oversight email
 23+$wgArticleFeedbackv5OversightEmailHelp = 'http://en.wikipedia.org/wiki/Wikipedia:Article_Feedback_Tool/Version_5/Help/Feedback_page_Oversighters';
 24+
 25+// admin User page for oversight email
 26+$wgArticleFeedbackv5OversightEmailAdminUser = 'http://en.wikipedia.org/wiki/User:Okeyes_(WMF)';
 27+
 28+
2529 // How long text-based feedback is allowed to be before returning an error.
2630 // Set to 0 to disable length checking entirely.
2731 $wgArticleFeedbackv5MaxCommentLength = 0;
Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5MailerJob.php
@@ -80,11 +80,10 @@
8181 */
8282 protected function composeMail( $requestor_name, $requestor_url, $page_name, $page_url, $feedback_permalink ) {
8383 global $wgPasswordSender, $wgPasswordSenderName, $wgNoReplyAddress, $wgRequest;
 84+ global $wgArticleFeedbackv5OversightEmailHelp, $wgArticleFeedbackv5OversightEmailAdminUser;
8485
8586 // build the subject
86 - $subject = wfMessage( 'articlefeedbackv5-email-request-oversight-subject' )->params(
87 - $requestor_name,
88 - $page_name )->escaped();
 87+ $subject = wfMessage( 'articlefeedbackv5-email-request-oversight-subject' )->escaped();
8988
9089 //text version, no need to escape since client will interpret it as plain text
9190 $body = wfMessage( 'articlefeedbackv5-email-request-oversight-body' )
@@ -94,7 +93,9 @@
9594 $feedback_permalink)
9695 ->params(
9796 $requestor_name,
98 - $page_name)
 97+ $page_name,
 98+ $wgArticleFeedbackv5OversightEmailHelp,
 99+ $wgArticleFeedbackv5OversightEmailAdminUser)
99100 ->text();
100101
101102 return array($subject, $body);

Follow-up revisions

RevisionCommit summaryAuthorDate
r113193bug 34090 - followup to r113104 - only sort by timestamp (sorting by log id w...emsmith22:56, 6 March 2012
r113228bug 34090 - followup to r113160emsmith14:05, 7 March 2012
r113247bug 34090 - db issue, remove one of the sorts from the query, use the ids arr...emsmith16:52, 7 March 2012
r113269bug 34090 - followup to r113247emsmith19:01, 7 March 2012
r113273bug 34090 - add javascript level hiding on request oversight IF autohidden is...emsmith19:22, 7 March 2012
r113287bug 34090 - usernames and formatted timestamps into red lines for hidden/over...emsmith20:22, 7 March 2012
r113311bug 34090 - fixing the username bugs - apparently using the data- stuff with ...emsmith22:34, 7 March 2012
r113317bug 34090 - js and css voodoo to make the element with the red lines appear a...emsmith23:01, 7 March 2012
r113370bug 34090 - make different titles for masking appear if it's been hidden or o...emsmith16:43, 8 March 2012
r113371bug 34090 - fixes for oversighter view for hide/oversight panelsemsmith17:51, 8 March 2012
r113383bug 34090 - not entirely necessary, but keeps $2 from showing up in hiders pa...emsmith19:25, 8 March 2012
r113384bug 34090 - fix for double red line issues when hiding an oversighted post ha...emsmith19:28, 8 March 2012
r113390bug 34090 - adding translation for "automatic hider" useremsmith19:44, 8 March 2012
r113392bug 34090 - followup to r113287 - adjusted localization documentationemsmith20:03, 8 March 2012
r113393bug 34090 - followup to r113370 - adjusted localization documentationemsmith20:05, 8 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r111211bug 34090 - Added a log namespace and log types for the Article Feedback v5 e...emsmith22:53, 10 February 2012
r111472bug 34090 - Added an additional column in the main feedback table to keep a c...emsmith19:14, 14 February 2012
r111474bug 34090 - remove a todo - take the note from the flag submission and save i...emsmith19:57, 14 February 2012
r111552bug 34090 - split activity notes into their own config for maximum length (th...emsmith16:07, 15 February 2012
r111557bug 34090 - changed structure of the link classes and ids per the following f...emsmith16:47, 15 February 2012
r111570bug 34090 - request oversight is now a counter - so you can request/unrequest...emsmith19:53, 15 February 2012
r111573bug 34090 - removed the "header" portion of the html generation from the acti...emsmith20:18, 15 February 2012
r111645bug 34090 - updated the filter count update script to get requested oversight...emsmith15:45, 16 February 2012
r112038bug 34090 - added additional counts for filters including unhidden, undeleted...emsmith20:28, 21 February 2012
r112039bug 34090 - fixed issue noted : if $feedback is false return nothing - not th...emsmith20:50, 21 February 2012
r112041bug 34090 - kill the -1 issue by never letting it get below 0emsmith21:08, 21 February 2012
r112115bug 34090 - no code changes, just fixing/adding keyword svn propertiesemsmith16:31, 22 February 2012
r112119bug 34090 - cast the naughty column so it can be signed, the greatest still k...emsmith16:57, 22 February 2012
r112142bug 34090 - toggle for atomic un/helpful changing (and elimination of an extr...emsmith20:37, 22 February 2012
r112147bug 34090 - note to self, watch the copy and paste errors...emsmith21:01, 22 February 2012
r112149bug 34090 - no upper limit, only lower limit - we can't get any worse then 0emsmith21:21, 22 February 2012
r112154bug 34090 - quick and dirty helper script to get missing documentation keysemsmith21:57, 22 February 2012
r112156bug 34090 - only send the activity header if continue < 1, make the more div ...emsmith22:14, 22 February 2012
r112161bug 34090 - fix limit and use old continue to determine if we do the headeremsmith23:15, 22 February 2012
r112218bug 34090 - make sure the name are right for hidden/unhidden logging (argh)emsmith16:44, 23 February 2012
r112225bug 34090 - unhidden and unoversight logic adjustmentsemsmith18:06, 23 February 2012
r112228bug 34090 - fix filter - needsoversight are always autohiddenemsmith19:16, 23 February 2012
r112230bug 34090 - let's try this again - needsoversight and declined will have hidd...emsmith19:38, 23 February 2012
r112232bug 34090 - hide and show shouldn't fiddle with oversight counts or declined ...emsmith19:48, 23 February 2012
r112599bug 34090 - follow up to r111211 - rename things to make them "less confusin...emsmith14:43, 28 February 2012
r112603bug 34090 - Add the logging of automated hide/show errors by the "Article Fee...emsmith15:21, 28 February 2012
r112604bug 34090 - can't believe there were no permissions checks in this - only del...emsmith15:38, 28 February 2012
r112610bug 34090 - change all sql updates to use escaping except for explicitly comm...emsmith16:22, 28 February 2012
r112611bug 34090 - take out implicit show and add returning user that hid/oversighte...emsmith17:02, 28 February 2012
r112627bug 34090 - follow up to r112599 - change to use getText since it's going int...emsmith18:53, 28 February 2012
r112825bug 34090 - insert custom attributes (sigh) for the user and formatted timest...emsmith18:14, 1 March 2012
r112830bug 34090 - follow up to r111474 - use truncate for choppingemsmith19:42, 1 March 2012
r113052bug 34090 - remaining backend feature in requirements, oversight email genera...emsmith18:04, 5 March 2012
r113062bug 34090 - follow up to r110520 1. change index 2. default of null for conti...emsmith18:54, 5 March 2012
r113073bug 34090 - follow up to r111472 part 1 - change to use getDbKey, check for b...emsmith19:48, 5 March 2012
r113082bug 34090 - follow up to r111471 - changed to use text()emsmith20:42, 5 March 2012
r113083bug 34090 - follow up to rr111472 part 2 - only use log_id for orderingemsmith20:48, 5 March 2012
r113104bug 34090 - follow up to rr111472 part 3 - totally redo the continue function...emsmith23:10, 5 March 2012
r113159bug 34090 - follow up to rr111472 part 4 and follow up to r111596 (same issue...emsmith17:37, 6 March 2012
r113160bug 34090 - follow up to rr111472 part 5 plural and number format action countemsmith17:48, 6 March 2012
r113161bug 34090 - follow up to rr111472 part 6 last of lego messagesemsmith17:53, 6 March 2012

Comments

#Comment by Siebrand (talk | contribs)   20:33, 6 March 2012

About "Hello, oversighters!": Is this an e-mail to a mailing list? If it is a an e-mail sent to many, I still think it should be as personal as possible, otherwise the call to action may be misunderstood ("there are many others, let them do it").

#Comment by Elizabeth M Smith (talk | contribs)   21:06, 6 March 2012

Yes - this is being sent to a mailing list - specifically oversight-en-wp and OTRS (with other language versions available later)

#Comment by Catrope (talk | contribs)   22:44, 6 March 2012
+<permalink of feedback post for which oversight was requested - $3>

I don't think the stuff in brackets was supposed to be in the literal e-mail; I'll ask Fabrice.

#Comment by Fabrice Florin (talk | contribs)   01:45, 7 March 2012

Thanks, Roan!

You are correct, the string in between the brackets is not supposed to be literally included in the email. It should be replaced by the actual permalink URL for the offending feedback post.

Siebrand, thanks for recommending that we replace "Hello oversighters!" with a more personal salutation. This wording was approved by Philippe Beaudette, who manages oversighter relations for Wikimedia. However, if you feel very strongly about this, I would be willing to recommend we change it to just "Hello," in future releases. But I would need to clear this again with Philippe, which I can do later this week, once you have confirmed that you would be satisfied with this wording change.

#Comment by Fabrice Florin (talk | contribs)   01:48, 7 March 2012

Also note that we have opened a special Bugzilla ticket for this:

Bug 35020 - Article Feedback Page v5 - Oversighter Email Notification https://bugzilla.wikimedia.org/show_bug.cgi?id=35020

That is the copy that will go in Thursday's release. I do not want to make any more copy changes for this release, since we have a lot of work to finish on Wednesday.

Thanks for your understanding ;o)

Status & tagging log