r113268 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113267‎ | r113268 | r113269 >
Date:19:00, 7 March 2012
Author:krinkle
Status:ok
Tags:
Comment:
Follows-up r113214: span ternary operator over multiple lines for readability
Modified paths:
  • /trunk/phase3/resources/mediawiki/mediawiki.util.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki/mediawiki.util.js
@@ -29,16 +29,18 @@
3030
3131 // Chrome on any platform
3232 } else if ( profile.name === 'chrome' ) {
33 -
 33+
3434 util.tooltipAccessKeyPrefix = (
35 - // Chrome on Mac
36 - profile.platform === 'mac' ? 'ctrl-option-' :
37 - // Chrome on Windows
38 - // (both alt- and alt-shift work, but alt-f triggers Chrome wrench menu
39 - // which alt-shift-f does not)
40 - profile.platform === 'win' ? 'alt-shift-' :
41 - // Chrome on Ubuntu (and other?)
42 - 'alt-'
 35+ profile.platform === 'mac'
 36+ // Chrome on Mac
 37+ ? 'ctrl-option-'
 38+ : profile.platform === 'win'
 39+ // Chrome on Windows
 40+ // (both alt- and alt-shift work, but alt-f triggers Chrome wrench menu
 41+ // which alt-shift-f does not)
 42+ ? 'alt-shift-'
 43+ // Chrome on other (Ubuntu?)
 44+ : 'alt-'
4345 );
4446
4547 // Non-Windows Safari with webkit_version > 526

Follow-up revisions

RevisionCommit summaryAuthorDate
r113936MFT r113268, r113892reedy17:35, 15 March 2012
r114015MFT r112918, r113214, r113268, r113277, r113312, r113415, r113454, r113737, r...reedy15:18, 16 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r113214[mw.util.tooltipAccessKeyPrefix] alt-shift for Chrome on Windows...krinkle02:58, 7 March 2012

Status & tagging log