r113267 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113266‎ | r113267 | r113268 >
Date:18:45, 7 March 2012
Author:emsmith
Status:ok
Tags:
Comment:
bug 35035 - apparently prototype not only doesn't RUN jobs it doesn't even have a jobs table - so to keep the entire thing from blowing up, overriding the insert method so if no email address is given, no job table insert is attempted
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5MailerJob.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5MailerJob.php
@@ -99,4 +99,21 @@
100100 return array($subject, $body);
101101 }
102102
 103+ /**
 104+ * Override insert - prototype does not even have a jobs table and will
 105+ * bomb miserably on this
 106+ *
 107+ * @return bool true on success
 108+ */
 109+ function insert() {
 110+ global $wgArticleFeedbackv5OversightEmails;
 111+
 112+ // if the oversight email address is empty we're going to just skip all this, but return true
 113+ if ( null === $wgArticleFeedbackv5OversightEmails ) {
 114+ return true;
 115+ }
 116+
 117+ return parent::insert();
 118+ }
 119+
103120 }
\ No newline at end of file

Follow-up revisions

RevisionCommit summaryAuthorDate
r114135bug 35035 - hide/show decline oversight link on oversight/unoversight and mak...emsmith13:06, 19 March 2012

Status & tagging log