r113936 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113935‎ | r113936 | r113937 >
Date:17:35, 15 March 2012
Author:reedy
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/wmf/1.19wmf1 (modified) (history)
  • /branches/wmf/1.19wmf1/includes (modified) (history)
  • /branches/wmf/1.19wmf1/includes/specials (modified) (history)
  • /branches/wmf/1.19wmf1/includes/specials/SpecialUndelete.php (modified) (history)
  • /branches/wmf/1.19wmf1/resources/mediawiki/mediawiki.util.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.19wmf1/includes/specials/SpecialUndelete.php
@@ -405,13 +405,12 @@
406406 $article->loadPageData( 'fromdbmaster' );
407407 $oldcountable = $article->isCountable();
408408
409 - $options = 'FOR UPDATE'; // lock page
410409 $page = $dbw->selectRow( 'page',
411410 array( 'page_id', 'page_latest' ),
412411 array( 'page_namespace' => $this->title->getNamespace(),
413412 'page_title' => $this->title->getDBkey() ),
414413 __METHOD__,
415 - $options
 414+ array( 'FOR UPDATE' ) // lock page
416415 );
417416 if( $page ) {
418417 $makepage = false;
Property changes on: branches/wmf/1.19wmf1/includes/specials
___________________________________________________________________
Modified: svn:mergeinfo
419418 Merged /trunk/phase3/includes/specials:r113892
Property changes on: branches/wmf/1.19wmf1/includes
___________________________________________________________________
Modified: svn:mergeinfo
420419 Merged /trunk/phase3/includes:r113892
Index: branches/wmf/1.19wmf1/resources/mediawiki/mediawiki.util.js
@@ -29,16 +29,18 @@
3030
3131 // Chrome on any platform
3232 } else if ( profile.name === 'chrome' ) {
33 -
 33+
3434 util.tooltipAccessKeyPrefix = (
35 - // Chrome on Mac
36 - profile.platform === 'mac' ? 'ctrl-option-' :
37 - // Chrome on Windows
38 - // (both alt- and alt-shift work, but alt-f triggers Chrome wrench menu
39 - // which alt-shift-f does not)
40 - profile.platform === 'win' ? 'alt-shift-' :
41 - // Chrome on Ubuntu (and other?)
42 - 'alt-'
 35+ profile.platform === 'mac'
 36+ // Chrome on Mac
 37+ ? 'ctrl-option-'
 38+ : profile.platform === 'win'
 39+ // Chrome on Windows
 40+ // (both alt- and alt-shift work, but alt-f triggers Chrome wrench menu
 41+ // which alt-shift-f does not)
 42+ ? 'alt-shift-'
 43+ // Chrome on other (Ubuntu?)
 44+ : 'alt-'
4345 );
4446
4547 // Non-Windows Safari with webkit_version > 526
Property changes on: branches/wmf/1.19wmf1
___________________________________________________________________
Modified: svn:mergeinfo
4648 Merged /trunk/phase3:r113268,113892

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r113268Follows-up r113214: span ternary operator over multiple lines for readabilitykrinkle19:00, 7 March 2012
r113892Fixed 'Illegal string offset 'LIMIT' in <b>C:\wamp\www\MediaWiki\includes\db\...aaron04:34, 15 March 2012

Status & tagging log