r113117 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r113116‎ | r113117 | r113118 >
Date:01:16, 6 March 2012
Author:jeroendedauw
Status:reverted (Comments)
Tags:
Comment:
follow up to r113115, rem not needed args
Modified paths:
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialContributions.php
——@@ -447,10 +447,7 @@
448448 Html::namespaceSelector( array(
449449 'selected' => $this->opts['namespace'],
450450 'all' => '',
451 - 'label' => null,
452451 ), array(
453 - 'name' => 'namespace',
454 - 'id' => 'namespace',
455452 'class' => 'namespaceselector',
456453 ) ) .
457454 '&#160;' .

Follow-up revisions

RevisionCommit summaryAuthorDate
r113123revert r113117 per CRhashar10:19, 6 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r113115get rid of deprecated method usage making people on education program test wi...jeroendedauw00:53, 6 March 2012

Comments

#Comment by Krinkle (talk | contribs)   01:35, 6 March 2012

Please don't remove the 'name' and 'id' attributes. The name attribute is vital to the submission of the form (and the value of it should not be assumed but specified in this script where it is used), same for the ID.

This isn't a regression compared to how it was before r113115, but while at it, might as well keep it.

I'm going to remove the default values for name/id in the Html::namespaceSelector in a moment.

#Comment by Hashar (talk | contribs)   10:20, 6 March 2012

I still think it is dumb to force developers to use explicit configuration when we could just use namespace/namespace as a convention.

Reverted the change anyway.

#Comment by Jeroen De Dauw (talk | contribs)   15:27, 6 March 2012

Right ok - I just removed the stuff because it was the same as the defaults, but if you're removing these, then sure.

Status & tagging log