r113115 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r113114‎ | r113115 | r113116 >
Date:00:53, 6 March 2012
Author:jeroendedauw
Status:ok (Comments)
Tags:
Comment:
get rid of deprecated method usage making people on education program test wiki go mad
Modified paths:
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialContributions.php
——@@ -444,7 +444,16 @@
445445 )
446446 ) .
447447 Xml::tags( 'td', null,
448 - Xml::namespaceSelector( $this->opts['namespace'], '' ) . '&#160;' .
 448+ Html::namespaceSelector( array(
 449+ 'selected' => $this->opts['namespace'],
 450+ 'all' => '',
 451+ 'label' => null,
 452+ ), array(
 453+ 'name' => 'namespace',
 454+ 'id' => 'namespace',
 455+ 'class' => 'namespaceselector',
 456+ ) ) .
 457+ '&#160;' .
449458 Html::rawElement( 'span', array( 'style' => 'white-space: nowrap' ),
450459 Xml::checkLabel(
451460 $this->msg( 'invert' )->text(),

Sign-offs

UserFlagDate
Rob Schnautz (WMF)tested19:31, 7 March 2012

Follow-up revisions

RevisionCommit summaryAuthorDate
r113117follow up to r113115, rem not needed argsjeroendedauw01:16, 6 March 2012
r113123revert r113117 per CRhashar10:19, 6 March 2012
r113272[Html::namespaceSelector] Remove default id/name attributes...krinkle19:14, 7 March 2012

Comments

#Comment by MZMcBride (talk | contribs)   01:39, 6 March 2012

How does deprecated method usage affect test wiki users?

#Comment by Jeroen De Dauw (talk | contribs)   15:25, 6 March 2012

Dev warnings on are on this test wiki so we catch more potential issues, so people are seeing deprecation notices from core as well.

Status & tagging log