r113116 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113115‎ | r113116 | r113117 >
Date:01:04, 6 March 2012
Author:kaldari
Status:ok
Tags:
Comment:
finishing the implementation for the large buttons
Modified paths:
  • /trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/ext.articleCreation.core.css (modified) (history)
  • /trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/left-arrow-blue-hover.png (added) (history)
  • /trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/left-arrow-blue.png (modified) (history)
  • /trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/left-arrow-green-hover.png (added) (history)
  • /trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/left-arrow-green.png (modified) (history)
  • /trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/left-arrow-orange-hover.png (added) (history)
  • /trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/left-arrow-orange.png (modified) (history)
  • /trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/left-arrow-red-hover.png (added) (history)
  • /trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/left-arrow-red.png (modified) (history)
  • /trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/right-arrow-blue-hover.png (added) (history)
  • /trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/right-arrow-blue.png (modified) (history)
  • /trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/right-arrow-green-hover.png (added) (history)
  • /trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/right-arrow-green.png (modified) (history)
  • /trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/right-arrow-orange-hover.png (added) (history)
  • /trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/right-arrow-orange.png (modified) (history)
  • /trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/right-arrow-red-hover.png (added) (history)
  • /trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/right-arrow-red.png (modified) (history)
  • /trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.user/ext.articleCreation.user.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.user/ext.articleCreation.user.js
@@ -98,11 +98,13 @@
9999 var article = wgPageName.substr( wgPageName.indexOf('/') + 1 );
100100 ac.trackAction( article, $(this).data('ac-button' ) + '_button_click' );
101101
 102+ // make button green
102103 $( this )
103 - //make it green
104104 .removeClass('ui-button-blue')
105105 .addClass('ui-button-green')
106 - .addClass('ac-button-selected')
 106+ .addClass('ac-button-selected');
 107+ // show interstitial
 108+ $( this )
107109 .parent()
108110 .find('.mw-ac-tooltip' )
109111 .hide()
Index: trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/ext.articleCreation.core.css
@@ -16,7 +16,7 @@
1717
1818 /* Buttons */
1919 .ac-article-button {
20 - width: 220px !important;
 20+ width: 225px !important;
2121 }
2222 .ui-button-large {
2323 padding: 5px 35px 7px 5px !important;
@@ -60,10 +60,10 @@
6161 .ac-arrow {
6262 position: absolute;
6363 top: 50%;
64 - right: 16px;
65 - width: 16px;
66 - height: 16px;
67 - margin-top: -9px;
 64+ right: 15px;
 65+ width: 23px;
 66+ height: 23px;
 67+ margin-top: -12px;
6868 }
6969
7070 .ac-arrow-forward {
@@ -75,6 +75,55 @@
7676 background: url(images/arrow_left.png) no-repeat;
7777 }
7878
 79+.ui-button-blue.ui-button-large .ac-arrow-forward {
 80+ /* @embed */
 81+ background: url(images/right-arrow-blue.png) no-repeat;
 82+}
 83+.ui-button-blue.ui-button-large:hover .ac-arrow-forward {
 84+ /* @embed */
 85+ background: url(images/right-arrow-blue-hover.png) no-repeat;
 86+}
 87+.ui-button-blue.ui-button-large .ac-arrow-back {
 88+ /* @embed */
 89+ background: url(images/left-arrow-blue.png) no-repeat;
 90+}
 91+.ui-button-blue.ui-button-large:hover .ac-arrow-back {
 92+ /* @embed */
 93+ background: url(images/left-arrow-blue-hover.png) no-repeat;
 94+}
 95+.ui-button-green.ui-button-large .ac-arrow-forward {
 96+ /* @embed */
 97+ background: url(images/right-arrow-green.png) no-repeat;
 98+}
 99+.ui-button-green.ui-button-large:hover .ac-arrow-forward {
 100+ /* @embed */
 101+ background: url(images/right-arrow-green-hover.png) no-repeat;
 102+}
 103+.ui-button-green.ui-button-large .ac-arrow-back {
 104+ /* @embed */
 105+ background: url(images/left-arrow-green.png) no-repeat;
 106+}
 107+.ui-button-green.ui-button-large:hover .ac-arrow-back {
 108+ /* @embed */
 109+ background: url(images/left-arrow-green-hover.png) no-repeat;
 110+}
 111+.ui-button-red.ui-button-large .ac-arrow-forward {
 112+ /* @embed */
 113+ background: url(images/right-arrow-red.png) no-repeat;
 114+}
 115+.ui-button-red.ui-button-large:hover .ac-arrow-forward {
 116+ /* @embed */
 117+ background: url(images/right-arrow-red-hover.png) no-repeat;
 118+}
 119+.ui-button-red.ui-button-large .ac-arrow-back {
 120+ /* @embed */
 121+ background: url(images/left-arrow-red.png) no-repeat;
 122+}
 123+.ui-button-red.ui-button-large:hover .ac-arrow-back {
 124+ /* @embed */
 125+ background: url(images/left-arrow-red-hover.png) no-repeat;
 126+}
 127+
79128 /* Tooltip Magic */
80129
81130 .mw-ac-tip {
Index: trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/right-arrow-red-hover.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/right-arrow-red-hover.png
___________________________________________________________________
Added: svn:mime-type
82131 + image/png
Index: trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/right-arrow-orange-hover.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/right-arrow-orange-hover.png
___________________________________________________________________
Added: svn:mime-type
83132 + image/png
Index: trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/left-arrow-green-hover.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/left-arrow-green-hover.png
___________________________________________________________________
Added: svn:mime-type
84133 + image/png
Index: trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/right-arrow-green.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/left-arrow-blue.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/left-arrow-red-hover.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/left-arrow-red-hover.png
___________________________________________________________________
Added: svn:mime-type
85134 + image/png
Index: trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/right-arrow-blue-hover.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/right-arrow-blue-hover.png
___________________________________________________________________
Added: svn:mime-type
86135 + image/png
Index: trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/left-arrow-orange-hover.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/left-arrow-orange-hover.png
___________________________________________________________________
Added: svn:mime-type
87136 + image/png
Index: trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/right-arrow-red.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/right-arrow-orange.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/left-arrow-green.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/right-arrow-green-hover.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/right-arrow-green-hover.png
___________________________________________________________________
Added: svn:mime-type
88137 + image/png
Index: trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/left-arrow-blue-hover.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/left-arrow-blue-hover.png
___________________________________________________________________
Added: svn:mime-type
89138 + image/png
Index: trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/right-arrow-blue.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/left-arrow-red.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/images/left-arrow-orange.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png

Status & tagging log