r112739 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r112738‎ | r112739 | r112740 >
Date:23:30, 29 February 2012
Author:reedy
Status:resolved
Tags:
Comment:
Fatal error: Call to a member function getTimestamp() on a non-object in /usr/local/apache/common-local/php-1.19/extensions/Collection/Collection.body.php on line 1148
Modified paths:
  • /trunk/extensions/Collection/Collection.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Collection/Collection.body.php
——@@ -1145,7 +1145,9 @@
11461146 }
11471147
11481148 $revision = Revision::newFromTitle( $title, $oldid );
1149 - $article['timestamp'] = wfTimestamp( TS_UNIX, $revision->getTimestamp() );
 1149+ if ( $title ) {
 1150+ $article['timestamp'] = wfTimestamp( TS_UNIX, $revision->getTimestamp() );
 1151+ }
11501152
11511153 $this->renderCollection( array( 'items' => array( $article ) ), $title, $writer );
11521154 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r112740Fix the utter fail of r112739reedy23:32, 29 February 2012
r112741MFT r112739, r112740reedy23:34, 29 February 2012

Status & tagging log