r112741 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112740‎ | r112741 | r112742 >
Date:23:34, 29 February 2012
Author:reedy
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/wmf/1.19wmf1/extensions/Collection (modified) (history)
  • /branches/wmf/1.19wmf1/extensions/Collection/Collection.body.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.19wmf1/extensions/Collection/Collection.body.php
@@ -1145,7 +1145,9 @@
11461146 }
11471147
11481148 $revision = Revision::newFromTitle( $title, $oldid );
1149 - $article['timestamp'] = wfTimestamp( TS_UNIX, $revision->getTimestamp() );
 1149+ if ( $revision ) {
 1150+ $article['timestamp'] = wfTimestamp( TS_UNIX, $revision->getTimestamp() );
 1151+ }
11501152
11511153 $this->renderCollection( array( 'items' => array( $article ) ), $title, $writer );
11521154 }
Property changes on: branches/wmf/1.19wmf1/extensions/Collection
___________________________________________________________________
Added: svn:mergeinfo
11531155 Merged /branches/sqlite/extensions/Collection:r58211-58321
11541156 Merged /trunk/phase3/extensions/Collection:r111002,111029,111034,111062,111067,111076,111085,111128,111144,111251
11551157 Merged /branches/new-installer/phase3/extensions/Collection:r43664-66004
11561158 Merged /branches/JSTesting/extensions/Collection:r100352-107913
11571159 Merged /branches/REL1_15/phase3/extensions/Collection:r51646
11581160 Merged /branches/wmf/1.18wmf1/extensions/Collection:r97508
11591161 Merged /branches/REL1_17/phase3/extensions/Collection:r81445,81448
11601162 Merged /trunk/extensions/Collection:r111043,111199,111218,111484,111575,111604,111659-111661,111668,111670,111688,111690,111698,111713,111715,111780,111796,111814,111947,112074,112153,112160,112166,112260,112282,112360,112517,112571,112613,112628,112739-112740

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112739Fatal error: Call to a member function getTimestamp() on a non-object in /us...reedy23:30, 29 February 2012
r112740Fix the utter fail of r112739reedy23:32, 29 February 2012

Status & tagging log