r112738 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112737‎ | r112738 | r112739 >
Date:23:28, 29 February 2012
Author:reedy
Status:ok
Tags:
Comment:
Do r112737 to 1.18wmf1 incase we end up needing to go back
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/ArticleFeedbackv5/api/ApiViewRatingsArticleFeedbackv5.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/ArticleFeedbackv5/api/ApiViewRatingsArticleFeedbackv5.php
@@ -56,11 +56,9 @@
5757 * Pulls a rollup row
5858 *
5959 * @param $pageId int the page id
60 - * @param $revisionLimit int go back only to this revision
61 - * @param $type string the type of row to fetch ('page' or 'revision')
6260 * @return array the rollup rows
6361 */
64 - private function fetchRollup( $pageId, $revisionLimit, $type ) {
 62+ private function fetchRollup( $pageId ) {
6563 $dbr = wfGetDB( DB_SLAVE );
6664 $where = array();
6765 $table = 'article_feedback_ratings_rollup';

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112737Remove extra unused parameters to save warnings...reedy23:25, 29 February 2012

Status & tagging log