r112608 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r112607‎ | r112608 | r112609 >
Date:16:08, 28 February 2012
Author:jdlrobson
Status:resolved (Comments)
Tags:
Comment:
show external link icon next to external links

this addresses bug 30831
Modified paths:
  • /trunk/extensions/MobileFrontend/stylesheets/beta_common.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/common.css (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/stylesheets/common.css
——@@ -165,6 +165,12 @@
166166 margin-right: 2em;
167167 }
168168
 169+/* TODO: support browsers which do not support data uris */
 170+a.external {
 171+ background: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAoAAAAKCAYAAACNMs+9AAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAFZJREFUeF59z4EJADEIQ1F36k7u5E7ZKXeUQPACJ3wK7UNokVxVk9kHnQH7bY9hbDyDhNXgjpRLqFlo4M2GgfyJHhjq8V4agfrgPQX3JtJQGbofmCHgA/nAKks+JAjFAAAAAElFTkSuQmCC) center right no-repeat;
 172+ padding-right: 13px;
 173+}
 174+
169175 #results {
170176 display: none;
171177 background-color: #ffffff;
Index: trunk/extensions/MobileFrontend/stylesheets/beta_common.css
——@@ -181,6 +181,12 @@
182182 margin-right: 2em;
183183 }
184184
 185+/* TODO: support browsers which do not support data uris */
 186+a.external {
 187+ background: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAoAAAAKCAYAAACNMs+9AAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAFZJREFUeF59z4EJADEIQ1F36k7u5E7ZKXeUQPACJ3wK7UNokVxVk9kHnQH7bY9hbDyDhNXgjpRLqFlo4M2GgfyJHhjq8V4agfrgPQX3JtJQGbofmCHgA/nAKks+JAjFAAAAAElFTkSuQmCC) center right no-repeat;
 188+ padding-right: 13px;
 189+}
 190+
185191 #results {
186192 display: none;
187193 background-color: #ffffff;

Follow-up revisions

RevisionCommit summaryAuthorDate
r112675use image rather than data uri...jdlrobson09:41, 29 February 2012

Comments

#Comment by Krinkle (talk | contribs)   23:10, 28 February 2012 
+/* TODO: support browsers which do not support data uris */
+a.external {
+	background: url(data:image/png;base64,iVBOR..

not using ResourceLoader and not having the magic @embed available is one thing, but please don't do this. This is impossible to maintain. Please just store the file in SVN and reference it here. This is making it very hard to look at this image, or to update it.

#Comment by Jdlrobson (talk | contribs)   09:41, 29 February 2012

Addressed in r112675

#Comment by Robmoen (talk | contribs)   19:27, 29 February 2012

r112706

Status & tagging log