r112609 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112608‎ | r112609 | r112610 >
Date:16:14, 28 February 2012
Author:jeroendedauw
Status:deferred
Tags:
Comment:
initial work on undeletion action
Modified paths:
  • /trunk/extensions/EducationProgram/EducationProgram.php (modified) (history)
  • /trunk/extensions/EducationProgram/actions/EPDeleteAction.php (modified) (history)
  • /trunk/extensions/EducationProgram/actions/EPHistoryAction.php (modified) (history)
  • /trunk/extensions/EducationProgram/actions/EPUndoAction.php (modified) (history)

Diff [purge]

Index: trunk/extensions/EducationProgram/EducationProgram.php
@@ -195,6 +195,7 @@
196196 $wgActions['epaddreviewer'] = 'EPAddReviewerAction';
197197 $wgActions['epundo'] = 'EPUndoAction';
198198 $wgActions['eprestore'] = 'EPRestoreAction';
 199+$wgActions['epundelete'] = 'EPUndeleteAction';
199200
200201 // Logging
201202 $wgLogTypes[] = 'institution';
Index: trunk/extensions/EducationProgram/actions/EPHistoryAction.php
@@ -1,7 +1,7 @@
22 <?php
33
44 /**
5 - * Abstract action for viewing the history of EPPageObject items.
 5+ * Action for viewing the history of EPPageObject items.
66 *
77 * @since 0.1
88 *
Index: trunk/extensions/EducationProgram/actions/EPDeleteAction.php
@@ -81,6 +81,8 @@
8282 *
8383 * @since 0.1
8484 *
 85+ * @param EPPageObject $object
 86+ *
8587 * @return boolean Success indicator
8688 */
8789 protected function doDelete( EPPageObject $object ) {
Index: trunk/extensions/EducationProgram/actions/EPUndoAction.php
@@ -1,7 +1,7 @@
22 <?php
33
44 /**
5 - * Abstract action for undoing a change to an EPPageObject.
 5+ * Action for undoing a change to an EPPageObject.
66 *
77 * @since 0.1
88 *
@@ -79,6 +79,8 @@
8080 *
8181 * @since 0.1
8282 *
 83+ * @param EPPageObject $object
 84+ *
8385 * @return boolean Success indicator
8486 */
8587 protected function doUndo( EPPageObject $object ) {
@@ -93,7 +95,7 @@
9496 }
9597
9698 /**
97 - * Display the restoration form for the provided EPPageObject.
 99+ * Display the undo revision form for the provided EPPageObject.
98100 *
99101 * @since 0.1
100102 *
@@ -129,7 +131,7 @@
130132 $out->addHTML( '<br />' );
131133
132134 $out->addHTML( Html::input(
133 - 'restore',
 135+ 'undo',
134136 wfMsg( $this->prefixMsg( 'undo-button' ) ),
135137 'submit',
136138 array(

Follow-up revisions

RevisionCommit summaryAuthorDate
r112612Follow up to r112609;jeroendedauw17:05, 28 February 2012

Status & tagging log