r112675 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112674‎ | r112675 | r112676 >
Date:09:41, 29 February 2012
Author:jdlrobson
Status:ok (Comments)
Tags:
Comment:
use image rather than data uri

follow up to r112608 c31607
Modified paths:
  • /trunk/extensions/MobileFrontend/stylesheets/beta_common.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/common.css (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/stylesheets/common.css
@@ -167,7 +167,7 @@
168168
169169 /* TODO: support browsers which do not support data uris */
170170 a.external {
171 - background: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAoAAAAKCAYAAACNMs+9AAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAFZJREFUeF59z4EJADEIQ1F36k7u5E7ZKXeUQPACJ3wK7UNokVxVk9kHnQH7bY9hbDyDhNXgjpRLqFlo4M2GgfyJHhjq8V4agfrgPQX3JtJQGbofmCHgA/nAKks+JAjFAAAAAElFTkSuQmCC) center right no-repeat;
 171+ background: url(images/external-link-ltr-icon.png) center right no-repeat;
172172 padding-right: 13px;
173173 }
174174
Index: trunk/extensions/MobileFrontend/stylesheets/beta_common.css
@@ -183,7 +183,7 @@
184184
185185 /* TODO: support browsers which do not support data uris */
186186 a.external {
187 - background: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAoAAAAKCAYAAACNMs+9AAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAFZJREFUeF59z4EJADEIQ1F36k7u5E7ZKXeUQPACJ3wK7UNokVxVk9kHnQH7bY9hbDyDhNXgjpRLqFlo4M2GgfyJHhjq8V4agfrgPQX3JtJQGbofmCHgA/nAKks+JAjFAAAAAElFTkSuQmCC) center right no-repeat;
 187+ background: url(images/external-link-ltr-icon.png) center right no-repeat;
188188 padding-right: 13px;
189189 }
190190

Follow-up revisions

RevisionCommit summaryAuthorDate
r112676add image for r112675...jdlrobson09:43, 29 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112608show external link icon next to external links...jdlrobson16:08, 28 February 2012

Comments

#Comment by Jdlrobson (talk | contribs)   09:43, 29 February 2012

Image is added in r112676 - my mistake.

Status & tagging log