r112188 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r112187‎ | r112188 | r112189 >
Date:06:36, 23 February 2012
Author:pgehres
Status:ok (Comments)
Tags:
Comment:
Tiny FU to r112187 fixing message for KE
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_common/country.specific.i18n.php (modified) (history)
  • /trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/_personal-information/KE.html (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/_personal-information/KE.html
——@@ -5,7 +5,7 @@
66 </tr>
77 <tr>
88 <td colspan="2">
9 - <input class="halfwidth" name="fname" value="@fname" type="text" placeholder="%donate_interface-donor-name%" id="fname"><input class="halfwidth leftmar" name="lname" value="@lname" type="text" placeholder="%donate_interface-donor-lname-alt%" id="lname">
 9+ <input class="halfwidth" name="fname" value="@fname" type="text" placeholder="%donate_interface-donor-name%" id="fname"><input class="halfwidth leftmar" name="lname" value="@lname" type="text" placeholder="%donate_interface-donor-lname%" id="lname">
1010 </td>
1111 </tr>
1212 <tr>
Index: trunk/extensions/DonationInterface/gateway_common/country.specific.i18n.php
——@@ -33,6 +33,9 @@
3434 $messages['pt']['donate_interface-donor-fname-gq'] = 'Nome';
3535 $messages['pt']['donate_interface-donor-lname-gq'] = 'Apelido';
3636
 37+/* KE - Kenya */
 38+$messages['en']['donate_interface-donor-lname-ke'] = 'Surname';
 39+
3740 /* TZ - Tanzania */
3841 $messages['en']['donate_interface-donor-lname-tz'] = 'Surname';
3942

Follow-up revisions

RevisionCommit summaryAuthorDate
r112262MFT r111992, r111993, r112177, r112187, r112188khorn23:10, 23 February 2012
r112287MFT r101785, r105938, r105941, r105953, r106109, r106158, r106259, r106366, r...khorn01:29, 24 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112187Adding forms for second week of Africa testing (ET, GQ, KE, and TZ) as well a...pgehres06:25, 23 February 2012

Comments

#Comment by Khorn (WMF) (talk | contribs)   20:00, 23 February 2012

Just one question: Are you planning on getting rid of donate_interface-donor-lname-alt in the interface.i18n, and all the other forms where you already use it? (AO, BW, CV, GW, etc... there's eight of them)

#Comment by Pgehres (WMF) (talk | contribs)   20:23, 23 February 2012

Eventually, yes, but I wanted to test with this set of forms before I made changes to all of the others. It also reduces (even if only by a little) the amount of CR for this deployment.

#Comment by Khorn (WMF) (talk | contribs)   20:36, 23 February 2012

Sweet. Just checking.

Status & tagging log