r105953 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105952‎ | r105953 | r105954 >
Date:23:07, 12 December 2011
Author:khorn
Status:deferred
Tags:fundraising 
Comment:
followup r105938
getVal_Escaped just uses htmlspecialchars directly now.
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_common/DonationData.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_common/DonationData.php
@@ -252,7 +252,9 @@
253253 */
254254 public function getVal_Escaped( $key ) {
255255 if ( $this->isSomething( $key ) ) {
256 - return $this->sanitizeInput( $this->normalized[$key], $key );
 256+ //TODO: If we ever start sanitizing in a more complicated way, we should move this
 257+ //off to a function and have both getVal_Escaped and sanitizeInput call that.
 258+ return htmlspecialchars( $this->normalized[$key], ENT_COMPAT, 'UTF-8', false );
257259 } else {
258260 return null;
259261 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r112287MFT r101785, r105938, r105941, r105953, r106109, r106158, r106259, r106366, r...khorn01:29, 24 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105938Data handling cleanup in DonationInterface, part 1 of [some]....khorn22:12, 12 December 2011

Status & tagging log