r112189 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112188‎ | r112189 | r112190 >
Date:07:47, 23 February 2012
Author:wikinaut
Status:deferred
Tags:
Comment:
changed the extension's version string constant name (back) to a unique value, so that it hoepfully never again conflicts with the already defined wiki-global VERSION constant.
Modified paths:
  • /trunk/extensions/WikiArticleFeeds/WikiArticleFeeds.php (modified) (history)
  • /trunk/extensions/WikiArticleFeeds/WikiArticleFeeds_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiArticleFeeds/WikiArticleFeeds_body.php
@@ -450,7 +450,7 @@
451451
452452 # Push feed header
453453 $tempWgVersion = $wgVersion;
454 - $wgVersion .= ' via WikiArticleFeeds ' . VERSION;
 454+ $wgVersion .= ' via WikiArticleFeeds ' . EXTENSION_WIKIARTICLEFEEDS_VERSION;
455455 $feed->outHeader();
456456 $wgVersion = $tempWgVersion;
457457
Index: trunk/extensions/WikiArticleFeeds/WikiArticleFeeds.php
@@ -4,7 +4,7 @@
55 * @author Jim R. Wilson, Thomas Gries
66 * @maintainer Thomas Gries
77 *
8 - * @version 0.700
 8+ * @version 0.701
99 * @copyright Copyright (C) 2007 Jim R. Wilson
1010 * @copyright Copyright (C) 2012 Thomas Gries
1111 * @license The MIT License - http://www.opensource.org/licenses/mit-license.php
@@ -56,6 +56,7 @@
5757 *
5858 * Versions
5959 *
 60+ * 0.701 version string constant renamed to make it wiki-unique
6061 * 0.700 rewritten into a four-file version with class
6162 * auto-discovery rss feedlinks come with the page title in it
6263 * 0.672 changed certain !empty() to isset()
@@ -122,7 +123,7 @@
123124 die( "This is not a valid entry point.\n" );
124125 }
125126
126 -define( 'VERSION', '0.700 20120222' );
 127+define( 'EXTENSION_WIKIARTICLEFEEDS_VERSION', '0.701 20120223' );
127128
128129 # Bring in supporting classes
129130 require_once( "$IP/includes/Feed.php" );
@@ -135,7 +136,7 @@
136137 'author' => array( 'Jim Wilson', 'Thomas Gries' ),
137138 'url' => '//www.mediawiki.org/wiki/Extension:WikiArticleFeeds',
138139 'descriptionmsg' => 'wikiarticlefeeds-desc',
139 - 'version' => VERSION,
 140+ 'version' => EXTENSION_WIKIARTICLEFEEDS_VERSION,
140141 );
141142
142143 $dir = dirname( __FILE__ ) . '/';

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112155rewritten into 4-file version. Introducing the new class WikiArticleFeeds. Ad...wikinaut22:13, 22 February 2012

Status & tagging log