r110949 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110948‎ | r110949 | r110950 >
Date:19:15, 8 February 2012
Author:catrope
Status:ok
Tags:
Comment:
(bug 33873) ProofreadPage JS wasn't loading on beta.wmflabs, probably because it wasn't using $ aliasing and $ is (probably?) redefined there. Changing $ to jQuery fixed it on beta.wmflabs so I guess that was the culprit then
Modified paths:
  • /trunk/extensions/ProofreadPage/proofread.js (modified) (history)
  • /trunk/extensions/ProofreadPage/proofread_article.js (modified) (history)
  • /trunk/extensions/ProofreadPage/proofread_index.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ProofreadPage/proofread_index.js
@@ -131,4 +131,4 @@
132132 form.elements['wpTextbox1'].value = result;
133133 }
134134
135 -$(document).ready( proofreadpage_index_init );
 135+jQuery( proofreadpage_index_init );
Index: trunk/extensions/ProofreadPage/proofread.js
@@ -954,9 +954,9 @@
955955 }
956956 }
957957
958 -$(document).ready( pr_init );
959 -$(document).ready( pr_init_tabs );
960 -$(document).ready( pr_initzoom );
 958+jQuery( pr_init );
 959+jQuery( pr_init_tabs );
 960+jQuery( pr_initzoom );
961961
962962
963963 /* Quality buttons */
@@ -1035,4 +1035,4 @@
10361036 }
10371037 }
10381038
1039 -$(document).ready( pr_add_quality_buttons );
 1039+jQuery( pr_add_quality_buttons );
Index: trunk/extensions/ProofreadPage/proofread_article.js
@@ -5,4 +5,4 @@
66 $( '#ca-nstab-main' ).after( '<li id="ca-proofread-source"><span>' + proofreadpage_source_href + '</span></li>' );
77 }
88
9 -$(document).ready( pr_add_source );
 9+jQuery( pr_add_source );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r110622Fix Bug #33873 - Proofread extension JS loading fully broken on 1.19...mah21:59, 2 February 2012
r110691attempt to fix bug 33873 - localBasePath shouldnt end with a slashkaldari00:04, 4 February 2012

Status & tagging log