r110691 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r110690‎ | r110691 | r110692 >
Date:00:04, 4 February 2012
Author:kaldari
Status:ok (Comments)
Tags:
Comment:
attempt to fix bug 33873 - localBasePath shouldnt end with a slash
Modified paths:
  • /trunk/extensions/ProofreadPage/ProofreadPage.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ProofreadPage/ProofreadPage.php
——@@ -57,7 +57,7 @@
5858
5959 # Client-side resources
6060 $prpResourceTemplate = array(
61 - 'localBasePath' => $dir,
 61+ 'localBasePath' => dirname( __FILE__ ),
6262 'remoteExtPath' => 'ProofreadPage'
6363 );
6464 $wgResourceModules += array(

Sign-offs

UserFlagDate
Reedyinspected00:21, 4 February 2012
Reedytested00:21, 4 February 2012

Follow-up revisions

RevisionCommit summaryAuthorDate
r110949(bug 33873) ProofreadPage JS wasn't loading on beta.wmflabs, probably because...catrope19:15, 8 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r110622Fix Bug #33873 - Proofread extension JS loading fully broken on 1.19...mah21:59, 2 February 2012

Comments

#Comment by Reedy (talk | contribs)   00:21, 4 February 2012

Tested locally, works fine in non debug mode :)

Status & tagging log