r110622 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110621‎ | r110622 | r110623 >
Date:21:59, 2 February 2012
Author:mah
Status:ok
Tags:
Comment:
Fix Bug #33873 - Proofread extension JS loading fully broken on 1.19

Patch from Zaran
Modified paths:
  • /trunk/extensions/ProofreadPage/ProofreadPage.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ProofreadPage/ProofreadPage.php
@@ -63,6 +63,7 @@
6464 $wgResourceModules += array(
6565 'ext.proofreadpage.page' => $prpResourceTemplate + array(
6666 'scripts' => 'proofread.js',
 67+ 'dependencies' => array( 'mediawiki.legacy.wikibits' ),
6768 'messages' => array(
6869 'proofreadpage_header',
6970 'proofreadpage_body',
@@ -106,4 +107,3 @@
107108 $wgHooks['EditPage::importFormData'][] = 'ProofreadPage::onEditPageImportFormData';
108109 $wgHooks['OutputPageParserOutput'][] = 'ProofreadPage::onOutputPageParserOutput';
109110 $wgHooks['wgQueryPages'][] = 'ProofreadPage::onwgQueryPages';
110 -

Follow-up revisions

RevisionCommit summaryAuthorDate
r110691attempt to fix bug 33873 - localBasePath shouldnt end with a slashkaldari00:04, 4 February 2012
r110949(bug 33873) ProofreadPage JS wasn't loading on beta.wmflabs, probably because...catrope19:15, 8 February 2012

Status & tagging log