r110948 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110947‎ | r110948 | r110949 >
Date:18:07, 8 February 2012
Author:maxsem
Status:ok (Comments)
Tags:
Comment:
Fix my stupid mistake in r110750 that resulted in fake "can't delete page" errors (bug 34245)
Modified paths:
  • /trunk/phase3/includes/WikiPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/WikiPage.php
@@ -1932,7 +1932,7 @@
19331933 $reason, $suppress = false, $id = 0, $commit = true, &$error = '', User $user = null
19341934 ) {
19351935 return $this->doDeleteArticleReal( $reason, $suppress, $id, $commit, $error, $user )
1936 - != WikiPage::DELETE_SUCCESS;
 1936+ == WikiPage::DELETE_SUCCESS;
19371937 }
19381938
19391939 /**

Sign-offs

UserFlagDate
Nikerabbitinspected21:32, 8 February 2012
Nikerabbittested21:32, 8 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r110750Fixed r63018: made it possible to delte half-baked images w/o descriptions, c...maxsem15:21, 6 February 2012

Comments

#Comment by Aaron Schulz (talk | contribs)   20:03, 8 February 2012

Weird, I read that as "equals" when I looked at it...

Status & tagging log